Safe triangle to improve submenu navigation #3438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 450d9d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Deploy preview for application-kit-custom-views ready! ✅ Preview Built with commit 993e6d8. |
ddouglasz
force-pushed
the
SHIELD-1090-safe-triangle-pattern-mainnav-sub-navigation
branch
from
b572f86
to
0efbff6
Compare
* feat(recoloring): follow up changes on rebranding * feat(recoloring): update changeset --------- Co-authored-by: Ddouglasz <douglas.egiemeh@gmail.com>
* Translate packages/i18n/data/core.json in fr_FR 84% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 84% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 84% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 85% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 86% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 86% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 88% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 88% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 89% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 89% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 90% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 90% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 91% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 92% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 92% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 92% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 92% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 92% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 93% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 93% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * chore: changeset added --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Carlos Cortizas <carlos.martines@commercetools.com>
…mote feature flags (#3439)
* Translate packages/i18n/data/core.json in zh_CN 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'zh_CN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in zh_CN 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'zh_CN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in zh_CN 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'zh_CN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in zh_CN 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'zh_CN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in zh_CN 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'zh_CN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in zh_CN 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'zh_CN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in zh_CN 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'zh_CN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in pt_BR 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'pt_BR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in pt_BR 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'pt_BR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in pt_BR 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'pt_BR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in pt_BR 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'pt_BR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in pt_BR 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'pt_BR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in pt_BR 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'pt_BR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in zh_CN 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'zh_CN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in zh_CN 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'zh_CN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * docs: changeset --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.com>
* fix(deps): update all flopflip packages to v13.4.1 * Create mean-yaks-bake.md --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tobias Deekens <tobias.deekens@commercetools.com>
* feat(rebranding notification): notify users of new rebranding feature * feat(rebranding annuncement): check when rebranding feature flag is enabled * feat(rebranding notification): move all logic to single file * feat(rebranding notification): remove unwanted condition * feat(rebranding notification): fix type issue * feat(rebranding notification): dialog should only show when feature flag is turned on * feat(rebranding notification): announcement dialog should only show when resolouring is true * feat(rebranding notification): cleanup unused code * feat(rebranding notification): rename change as primarily recolouring --------- Co-authored-by: Ddouglasz <douglas.egiemeh@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* ci: run integration tests for starter templates * ci: fix test command * ci: fix test command * chore: set resolutions for msw transitive dependency
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Translate packages/i18n/data/core.json in es 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'es'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in es 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'es'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in de 94% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'de'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in en 98% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'en'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in es 92% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'es'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in zh_CN 92% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'zh_CN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 92% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in de 92% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'de'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in pt_BR 98% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'pt_BR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 92% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 92% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Create thirty-needles-cover.md * Translate packages/i18n/data/core.json in de 93% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'de'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 98% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.com>
Co-authored-by: Ddouglasz <douglas.egiemeh@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix(deps): update all dependencies * fix: type checks * chore: update uikit and docs kit * revert: docs kit * fix: update react inlt * fix: attempt to fix e2e * chore: uikit 19 * chore: changeset --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Kacper Krzywiec <krzywiec@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat(drawer component docs): playground example for drawer component * feat(drawer component docs): add changeset * feat(drawer component docs): fix text case * feat(drawer component docs): modify hide controls props to string --------- Co-authored-by: Ddouglasz <douglas.egiemeh@gmail.com>
* chore: removing rebranding modal * chore: remove local storage value for rebranding modal
* chore(deps): update dependency @types/express-unless to v2 * refactor(express): remove unused dependency --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Carlos Cortizas <carlos.martines@commercetools.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Translate packages/i18n/data/core.json in zh_CN 99% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'zh_CN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in es 99% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'es'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in de 99% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'de'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in en 99% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'en'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 99% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in pt_BR 99% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'pt_BR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in en 99% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'en'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in es 99% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'es'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in pt_BR 99% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'pt_BR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in de 99% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'de'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in fr_FR 99% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate packages/i18n/data/core.json in zh_CN 99% of minimum 75% reviewed source file: 'packages/i18n/data/core.json' on 'zh_CN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
…ngStandalonePriceValidity error codes (#3517) * fix: add missing message for `OverlappingStandalonePriceValidity` error code * test: add cases for price related messages * feat: add message for `OverlappingPriceValidity` error code * fix: add changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore: add import export api target * chore: add changeset file --------- Co-authored-by: Carlos Cortizas <carlos.martines@commercetools.com>
* ci: update gh pnpm install action * ci: add missing gh action input declaration
* fix(deps): update all dependencies * refactor: debug cypress issue * chore: update generated types * fix(deps): update all dependencies * chore: fix dependencies which cannot be updated * docs: changeset * chore: update lockfile * chore: downgrade apollo client * chore: downgrade typescript * fix: types * chore: update lockfile * chore: downgrade preconstruct --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Carlos Cortizas <carlos.martines@commercetools.com> Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.com>
…PriceValidity error codes messages (#3529)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…3.9 (#3518) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: add isUserAdminOfCurrentProject field to application context * feat: remove deprecated value * Create many-otters-drum.md * chore: test ci * refactor: update generated types --------- Co-authored-by: tdeekens <tobias.deekens@commercetools.com> Co-authored-by: Carlos Cortizas <carlos.martines@commercetools.com>
* fix(deps): update all flopflip packages to v14.0.1 * Create cyan-planes-protect.md --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tobias Deekens <tobias.deekens@commercetools.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix(deps): update all test-data packages to v8 * refactor(test-data): remove deprecated faker function call * chore: changeset added --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Carlos Cortizas <carlos.martines@commercetools.com>
ddouglasz
deleted the
SHIELD-1090-safe-triangle-pattern-mainnav-sub-navigation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Safe triangle to improve submenu navigation
Description
Improve the submenu navigation by adding a safe area for users to smoothly navigate diagonally between the main menu and the submenu items, without awkwardly going out of focus.
Background:
https://ishadeed.com/article/target-size#safe-triangle-target-areas
TODO: