Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isUserAdminOfCurrentProject field to application context #3523

Merged
merged 6 commits into from May 16, 2024

Conversation

obulaworld
Copy link
Contributor

@obulaworld obulaworld commented May 13, 2024

Summary

This PR adds isUserAdminOfCurrentProject to application-context.

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 8:28am

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 7a9cf21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/application-components Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Patch
@commercetools-applications/merchant-center-custom-view-template-starter Patch
@commercetools-local/playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-frontend/cypress Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-frontend/react-notifications Patch
@commercetools-website/components-playground Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@obulaworld obulaworld marked this pull request as ready for review May 13, 2024 11:53
@obulaworld obulaworld requested a review from a team as a code owner May 13, 2024 11:53
@@ -96,7 +96,6 @@ const defaultUser = {
launchdarklyTrackingSubgroup: 'dev',
launchdarklyTrackingId: '111',
launchdarklyTrackingTeam: undefined,
launchdarklyTrackingTenant: 'gcp-eu',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is deprecated and was causing the test to fail. I guess it has been replaced by launchdarklyTrackingCloudEnvironment.

@CarlosCortizasCT CarlosCortizasCT changed the title FCT-704: Add isUserAdminOfCurrentProject field to application context Add isUserAdminOfCurrentProject field to application context May 14, 2024
@CarlosCortizasCT
Copy link
Contributor

Hello,

I pushed this commit to include refreshed types and schemas from the backend services as I found out this helps with the error we were having (although I'm not sure why).

Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@obulaworld obulaworld merged commit 7e48e90 into main May 16, 2024
18 checks passed
@obulaworld obulaworld deleted the FCT-704-user-project-admin-status branch May 16, 2024 08:26
@ct-changesets ct-changesets bot mentioned this pull request May 16, 2024
ddouglasz pushed a commit that referenced this pull request May 22, 2024
* feat: add isUserAdminOfCurrentProject field to application context

* feat: remove deprecated value

* Create many-otters-drum.md

* chore: test ci

* refactor: update generated types

---------

Co-authored-by: tdeekens <tobias.deekens@commercetools.com>
Co-authored-by: Carlos Cortizas <carlos.martines@commercetools.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants