Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy improvement #1054

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Mypy improvement #1054

wants to merge 4 commits into from

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Apr 5, 2024

Description

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

#1053

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.49%. Comparing base (120d514) to head (1eb5aab).
Report is 255 commits behind head on master.

Files Patch % Lines
commitizen/commands/check.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
+ Coverage   97.33%   97.49%   +0.15%     
==========================================
  Files          42       55      +13     
  Lines        2104     2431     +327     
==========================================
+ Hits         2048     2370     +322     
- Misses         56       61       +5     
Flag Coverage Δ
unittests 97.49% <95.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant