V3.x #453
Draft
V3.x #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the execa library when invoing git
On my system `stdout` was undeifned and resulted in "Cannot read property 'trim' of undefined". Switching this code to also use execa fixes that issue.
BREAKING CHANGE: Node.js 0.12 is no longer supported
…416) Adapters should depend directly on inquirer instead of using the one provided by us.
BREAKING CHANGE: czConfig is no longer read for config
This replaces ghooks with husky. ghooks is deprecated in favor of husky. Contributors may need to For commitizen developers, you need to do the following: 1. rm -rf .git/hooks 2. rm -rf node_modules 3. run npm install. Closes #410
|
Hey there. Thanks for doing this! Can you update the conflicts? |
|
cc @saketjajoo |
|
Since this is a new major release, maybe consider upgrading the ancient inquirer version? Also I remember reading thoughts about letting The adapter supply their own version of inquirer (this would greatly reduce the risk of breaking in the feature)? One could consider dropping support for non LTS/current versions aswell and start using features like package-lock.json or yarn.lock for better stability. |
|
This PR is so old. I'm converting it to a draft until someone has time to look at it and see if it is still valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.