Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optional exclamation mark (!) #155

Open
EndzeitBegins opened this issue Oct 1, 2021 · 1 comment
Open

Add support for optional exclamation mark (!) #155

EndzeitBegins opened this issue Oct 1, 2021 · 1 comment

Comments

@EndzeitBegins
Copy link

EndzeitBegins commented Oct 1, 2021

According to conventional commits, a breaking change can also be denoted by adding an exclamation mark (!) after type / scope.
This improves the visibility of breaking changes by making them visible in the commit message header.

fix(api)!: omit keys of undefined elements in JSON responses

BREAKING CHANGE: < reason here >

We started to take a look at Commitizen in combination with @digitalroute/cz-conventional-changelog-for-jira. Instead of contributing the feature there, I thought it would be more effective to contribute this feature "upstream" instead, as it has nothing to do with Jira.

Any thoughts about this? Are PRs welcome?
Thanks in advance for the great work so far!

@cgaube
Copy link

cgaube commented Feb 18, 2022

One alternative you can do until this is managed via commitzen is to use the -e option when committing

git cz -a -e

it will trigger the helper where you can select the types etc then when everything is done will open the commit message and allow you to edit it (via vim or other editor)- from there you can manually add the ! yourself

annoying for sure

Any thoughts about this? Are PRs welcome?

I would assume that any PR are welcome..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants