Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine.ts): Fix typo in subject prompt #73

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Infiltrator
Copy link

Hopefully you are nice and relaxed when writing your commit messages.

Hopefully you are nice and relaxed when writing your commit messages.
@LinusU
Copy link
Contributor

LinusU commented Oct 19, 2018

Dupe of #72? 😄

@Infiltrator
Copy link
Author

Infiltrator commented Oct 21, 2018

Ah, I see what you are trying to say now. The problem is that "short" is an adjective, which applies to "description", but "tense" is a noun, to which "imperative" applies as an adjective, so to make it grammatically correct, it should be "short, imperatively tensed description", with "tense" becoming a past participle (effectively making it an adjective) for "description", and "imperative" becoming an adverb describing "imperatively".

Having said that, "Write a short, imperatively tensed description of the change:" might sound funny to some people, so some other ways are:

  • "Write a short description of the change in the imperative tense:"
  • "Write a short description of the change (use the imperative tense):"
  • "Using the imperative tense, write a short description of the change:"

Or, if only one other person and I have found this a problem and everybody else understands what you are trying to say, then you can leave it be.

@LinusU
Copy link
Contributor

LinusU commented Oct 24, 2018

I'd be happy with an update to the text, especially since this keeps coming up ☺️

ping @commitizen/admins

@Infiltrator
Copy link
Author

Sure thing. Any preferences for phrasing? Personally, I like "Write a short, imperatively tensed description of the change", but I know that might sound arcane to some people. I like the second of the three alternatives, because the parentheses draw the reader's attention, and it is another imperative phrase, which will make people more likely to follow it.

@Infiltrator
Copy link
Author

Oh, and as pointed out in #71, it should be "mood", not "tense", as grammatical tense is only about time. It kept feeling very strange to me every time that I read or wrote it but could not quite put my finger on it. I will change that at the same time in the PR.

@jimthedev
Copy link
Member

If you change this to mood I'll merge it.

@@ -92,7 +92,7 @@ module.exports = function(options) {
name: 'subject',
message: function(answers) {
return (
'Write a short, imperative tense description of the change (max ' +
'Write a short description of the change as a command/instruction (max ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimthedev How's this instead? I think this is better than "Write a short, imperatively moody description..." ;P

https://chris.beams.io/posts/git-commit/#imperative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants