Payments service integration #13
Conversation
pom.xml
Outdated
| @@ -142,6 +142,16 @@ | |||
| </annotationProcessorPaths> | |||
| </configuration> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>com.google.cloud.tools</groupId> | |||
There was a problem hiding this comment.
If this plugin is added to create an image then you dont need it.
| public PaymentApi createPaymentSession(String passThroughHeader, Transaction transaction) throws ServiceException { | ||
| // below is the dummy body, resource should be the payment link generated by transactcion api | ||
| PaymentSessionApi paymentSessionApi = new PaymentSessionApi(); | ||
| paymentSessionApi.setRedirectUri("https://cidev.aws.chdev.org/transactions/117524-754816-491724/company/10000025/confirmation"); |
There was a problem hiding this comment.
I am guessing these value will depend on the environment so we need to use variables.
There was a problem hiding this comment.
addressed the comments
sardhani-ch
force-pushed
the
payments-service-integration
branch
3 times, most recently
from
96360ba
to
113e2d1
Compare
|
CI: No security warnings found |
sardhani-ch
force-pushed
the
payments-service-integration
branch
from
c633e3d
to
7755426
Compare
|
CI: No security warnings found |
|
CI: No security warnings found |
|
CI: No security warnings found |
| private static EnvironmentReader environmentReader = new EnvironmentReaderImpl(); | ||
|
|
||
| public PaymentApi createPaymentSession(String passThroughHeader, Transaction transaction) throws ServiceException { | ||
| //below is the dummy body, Note that resource should be the payment link generated by transactcion api |
There was a problem hiding this comment.
You can Add TODO block instead of comment, so it won't get lost
There was a problem hiding this comment.
comments addressed
| @Autowired | ||
| private PaymentsService paymentsService; | ||
|
|
||
| @PostMapping(value = "/transaction/payments/{id}") |
There was a problem hiding this comment.
need to change the url. Id being passed id is transactionId so "/transaction/{id}/payments" makes more sense, as currently it looks like you are passing paymentId
There was a problem hiding this comment.
comments addressed
|
CI: No security warnings found |
|
CI: No security warnings found |
…to payments-service-integration
|
CI: No security warnings found |
|
CI: No security warnings found |
|
CI: No security warnings found |
|
SonarQube Quality Gate
|
|
CI: No security warnings found |
No description provided.