Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ?. PrivateIdentifier test #1612

Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 28, 2020

Recently proposal-class-fields has enabled optional chain support. Created a new subtest for private properties since it is only fixed in V8 8.4.

preset-env will use this data to transform ?. PrivateIdentifier on Chrome 80 - 83, where both optional chaining and private properties are supported.

Tracking bugs

@chicoxyzzy chicoxyzzy merged commit 4f9c321 into compat-table:gh-pages Apr 28, 2020
jridgewell added a commit to jridgewell/compat-table that referenced this pull request Apr 30, 2020
This was also recently approved in TC39. I collected the results by taking the maximum of the optional chain and private instance fields results, then manually verifying the supported browsers. Only Chrome has it so far.

Re: compat-table#1612
ljharb pushed a commit to jridgewell/compat-table that referenced this pull request Apr 30, 2020
This was also recently approved in TC39. I collected the results by taking the maximum of the optional chain and private instance fields results, then manually verifying the supported browsers. Only Chrome has it so far.

Re: compat-table#1612
ljharb pushed a commit to jridgewell/compat-table that referenced this pull request May 1, 2020
This was also recently approved in TC39. I collected the results by taking the maximum of the optional chain and private instance fields results, then manually verifying the supported browsers. Only Chrome has it so far.

Re: compat-table#1612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants