Split Unicode Escape tests #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Babel is [concerned](babel/babel#11377) with a few unique cases: 1. Escapes in strings 2. Escapes in bare identifiers 3. Escapes in the property keys These require a slightly different transform for each, and only strings and property keys are actually transformable. If we encounter an escape in a bare identifier, we currently error out.
jridgewell
commented
May 18, 2020
| return o['\ud800\udec0'] === 2; | ||
| */}, | ||
| res: { | ||
| ejs: true, |
There was a problem hiding this comment.
I reused the same test results, since this was split from the previous test. I imagine everything will pass them both individually.
| return o.\u{102C0} === 2; | ||
| */}, | ||
| res: { | ||
| edge12: true, |
There was a problem hiding this comment.
These are the only implementations I could manually verify.
jridgewell
force-pushed
the
split-unicode-escape-tests
branch
from
ca7b85b
to
020018c
Compare
ljharb
approved these changes
May 18, 2020
chicoxyzzy
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Babel is concerned with a few unique cases:
These require a slightly different transform for each, and only strings and property keys are actually transformable. If we encounter an escape in a bare identifier, we currently error out.