Add results for Hermes 0.8.1 to 0.11.0 #1808
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afmenez
suggested changes
May 12, 2022
| @@ -4936,7 +4936,74 @@ | |||
| "test_suites": [ | |||
| "es5", | |||
| "es6", | |||
| "es2016plus" | |||
| "es2016plus", | |||
There was a problem hiding this comment.
You don't need to add the test_suites field if all the test suites are enabled, this is the default.
| "short": "Hermes 0.8.1", | ||
| "platformtype": "engine", | ||
| "release": "2021-07-12", | ||
| "obsolete": false, |
There was a problem hiding this comment.
All these versions are receiving active support? The retired versions should be "obsolete": false, the versions that are not in use anymore should be "obsolete": "very".
There was a problem hiding this comment.
Cheers, just waiting for some feedback from Hermes on that.
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds results for Hermes versions:
0.7.0 (already mostly present)
0.8.0
0.9.0
0.10.0
0.11.0
I'm part of the React Native team at Meta, and we're looking to give more visibility to Hermes feature support as we move towards Hermes as default for React Native. Thanks for providing this platform!
(NB: In practice, because Hermes is focused on bytecode performance over syntax support, JS support in React Native is heavily augmented by Babel - I'm planning to follow up this PR with the addition of "React Native" as a runtime from RN 0.68 - effectively this will be Hermes + RN's bundled Babel preset)
Preview: https://robhogan.github.io/compat-table/es6/#hermes0_11_0
CC @neildhar
(Currently in draft to give the Hermes team a chance to review footnotes, etc.)