Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rhino 1.7.15 #1891

Open
wants to merge 7 commits into
base: gh-pages
Choose a base branch
from
Open

Add Rhino 1.7.15 #1891

wants to merge 7 commits into from
+1,526 −141

Conversation

gausie
Copy link
Contributor

@gausie gausie commented May 8, 2024

  • Add new version environment
  • Update instructions at the top of rhino.js
  • Update newly passing tests for Rhino 1.7.15
  • Fix some old tests that were erroneously marked as true, thus the new falses are not regressions

@gausie gausie mentioned this pull request May 8, 2024
Open
@ljharb ljharb requested a review from chicoxyzzy May 28, 2024 06:02
chicoxyzzy
chicoxyzzy approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@chicoxyzzy chicoxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Can you please rebase and regenerate HTML files?

@ljharb
Copy link
Member

ljharb commented May 29, 2024

@chicoxyzzy ill take care of it :-) reminder that PRs still need two green checks before they can be landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chicoxyzzy chicoxyzzy chicoxyzzy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gausie @ljharb @chicoxyzzy