-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump node from 10.20.1-alpine to 14.4.0-alpine in /server #325
Conversation
Bumps node from 10.20.1-alpine to 14.4.0-alpine. Signed-off-by: dependabot[bot] <support@github.com>
*With this bcrypt package upgrade patch from 3.0.0 to 3.0.8: https://gist.github.com/patcon/4461f73d2814e7d03a50076a9c6bd0dd Error
EDIT:
EDIT2: ok, seems it's just bcrypt that holds us back. Fixed in patch above. |
Seems that we might be ablet to upgrade server to running on the newest node 14, if we'd like. Any reason not to -- other package incompatibilities that @pol-is/core is aware of? We could just apply the linked patch above to this issue, and see whether our e2e tests pass...? |
TODO: apply the patch linked above, and merge to latest patch: https://gist.github.com/patcon/4461f73d2814e7d03a50076a9c6bd0dd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…acy#325) * Bump node from 10.20.1-alpine to 14.4.0-alpine in /server Bumps node from 10.20.1-alpine to 14.4.0-alpine. Signed-off-by: dependabot[bot] <support@github.com> * Upgrade bcrypt v3.0.0 to v3.0.8 in order to work with Node v12+. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick Connolly <patrick.c.connolly@gmail.com>
…acy#325) * Bump node from 10.20.1-alpine to 14.4.0-alpine in /server Bumps node from 10.20.1-alpine to 14.4.0-alpine. Signed-off-by: dependabot[bot] <support@github.com> * Upgrade bcrypt v3.0.0 to v3.0.8 in order to work with Node v12+. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick Connolly <patrick.c.connolly@gmail.com>
Bumps node from 10.20.1-alpine to 14.4.0-alpine.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)