Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node from 10.20.1-alpine to 14.4.0-alpine in /server #325

Merged
merged 2 commits into from
Jun 20, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 15, 2020

Bumps node from 10.20.1-alpine to 14.4.0-alpine.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps node from 10.20.1-alpine to 14.4.0-alpine.

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker labels Jun 15, 2020
@patcon patcon added ⚒️ infrastructure Re: automation, continuous integration. 🔩 p:server and removed docker labels Jun 15, 2020
@patcon
Copy link
Contributor

patcon commented Jun 16, 2020

We should find the newest node version that will build all containers. This makes caching simpler.

node image status status *
14 (14.4.0)
13 (13.14.0) --
12 (12.18.0)
12.5.0 --
12.0.0 --
11 (11.15.0)
10.20.1

*With this bcrypt package upgrade patch from 3.0.0 to 3.0.8: https://gist.github.com/patcon/4461f73d2814e7d03a50076a9c6bd0dd

Error

Long build failure that looks like this: brianc/node-libpq#62

Node version is different, but common factor is node-gyp@3.8.0, which is very far behind current v7.0.0 of today.

EDIT: Seems this is the solution:
brianc/node-pg-native#71 (comment)

I was able to get this working for Heroku and Node v12.13.1 by adding libpq v1.8.9 to my package.json (to allow for the latest fix)

Makes sense, since a fix was released (untagged), as seen in commit log:
https://github.com/brianc/node-libpq/commits/master

EDIT2: ok, seems it's just bcrypt that holds us back. Fixed in patch above.

@patcon
Copy link
Contributor

patcon commented Jun 16, 2020

Seems that we might be ablet to upgrade server to running on the newest node 14, if we'd like.

Any reason not to -- other package incompatibilities that @pol-is/core is aware of? We could just apply the linked patch above to this issue, and see whether our e2e tests pass...?

@patcon patcon marked this pull request as draft June 16, 2020 16:27
@patcon
Copy link
Contributor

patcon commented Jun 16, 2020

TODO: apply the patch linked above, and merge to latest 14.x once passing.

patch: https://gist.github.com/patcon/4461f73d2814e7d03a50076a9c6bd0dd

@patcon patcon marked this pull request as ready for review June 16, 2020 19:10
@patcon patcon linked an issue Jun 18, 2020 that may be closed by this pull request
Copy link
Member

@metasoarous metasoarous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patcon patcon merged commit bb2f6ef into dev Jun 20, 2020
@patcon patcon deleted the dependabot/docker/server/node-14.4.0-alpine branch June 20, 2020 20:54
raulsperoni pushed a commit to proyectourgente/polis that referenced this pull request Sep 1, 2021
…acy#325)

* Bump node from 10.20.1-alpine to 14.4.0-alpine in /server

Bumps node from 10.20.1-alpine to 14.4.0-alpine.

Signed-off-by: dependabot[bot] <support@github.com>

* Upgrade bcrypt v3.0.0 to v3.0.8 in order to work with Node v12+.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Patrick Connolly <patrick.c.connolly@gmail.com>
raulsperoni pushed a commit to proyectourgente/polis that referenced this pull request Oct 26, 2021
…acy#325)

* Bump node from 10.20.1-alpine to 14.4.0-alpine in /server

Bumps node from 10.20.1-alpine to 14.4.0-alpine.

Signed-off-by: dependabot[bot] <support@github.com>

* Upgrade bcrypt v3.0.0 to v3.0.8 in order to work with Node v12+.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Patrick Connolly <patrick.c.connolly@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ⚒️ infrastructure Re: automation, continuous integration. 🔩 p:server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade our nodejs versions to newest functional versions
2 participants