Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented caching with webpack #62

Merged
merged 4 commits into from
May 26, 2020
Merged

Implemented caching with webpack #62

merged 4 commits into from
May 26, 2020

Conversation

MohamedBeydoun
Copy link
Member

@MohamedBeydoun MohamedBeydoun commented May 25, 2020 •
edited

Resolves #59

Added timestamp to output files during build

@MohamedBeydoun MohamedBeydoun added the enhancement New feature or request label May 25, 2020
@MohamedBeydoun MohamedBeydoun self-assigned this May 25, 2020
ValerianClerc
ValerianClerc previously approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@ValerianClerc ValerianClerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know that I don't know anything about NGINX, so I'll just throw in this approval.

@idodin
Copy link
Member

idodin commented May 25, 2020

I'm not sure I agree with this change - can we not update webpack configuration to hash files? That would allow users to cache but force retrieval of resources on new builds/releases

@MohamedBeydoun MohamedBeydoun requested review from idodin and ValerianClerc and removed request for ValerianClerc May 25, 2020 15:24
@MohamedBeydoun MohamedBeydoun linked an issue May 25, 2020 that may be closed by this pull request
Disable caching in browser #59
Open
@MohamedBeydoun MohamedBeydoun changed the title Added nginx conf to remove caching Implemented proper caching with webpack May 25, 2020
@MohamedBeydoun MohamedBeydoun changed the title Implemented proper caching with webpack Implemented caching with webpack May 25, 2020
ValerianClerc
ValerianClerc requested changes May 26, 2020
View reviewed changes
public/index.html Show resolved Hide resolved
idodin
idodin approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@idodin idodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@MohamedBeydoun MohamedBeydoun merged commit 91a7bfa into dev May 26, 2020
@MohamedBeydoun MohamedBeydoun deleted the patches/disable-caching branch May 26, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idodin idodin idodin approved these changes

@ValerianClerc ValerianClerc ValerianClerc approved these changes

Assignees

@MohamedBeydoun MohamedBeydoun

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable caching in browser
3 participants
@MohamedBeydoun @idodin @ValerianClerc