Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly more controversial bumpings #4503

Merged
merged 9 commits into from Dec 28, 2022
Merged

Slightly more controversial bumpings #4503

merged 9 commits into from Dec 28, 2022

Conversation

mattgodbolt
Copy link
Member

libs and ts tooling update

  • latest sentry, tar-stream, which, yamljs versions
  • latest css minimizer
  • latest eslint-* stuff
  • latest webpack manifest
  • Applies all the automatic fixes for newer lint rules

- latest sentry, tar-stream, which, yamljs versions
- latest css minimizer
- latest eslint-* stuff
- latest webpack manifest
- Applies all the automatic fixes for newer lint rules
@@ -1200,7 +1199,7 @@
return [{text: 'Failed to run compiler to get Rust MIR'}];
}
if (await utils.fileExists(mirPath)) {
const content = await fs.readFile(mirPath, 'utf-8');
const content = await fs.readFile(mirPath, 'utf8');

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This path depends on a [user-provided value](1).
@@ -2497,7 +2496,7 @@
output.currentPassOutput = '';

if (dumpFileName && (await fs.pathExists(dumpFileName)))
output.currentPassOutput = await fs.readFile(dumpFileName, 'utf-8');
output.currentPassOutput = await fs.readFile(dumpFileName, 'utf8');

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This path depends on a [user-provided value](1).
Copy link
Member

@jeremy-rifkin jeremy-rifkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me at face value. I haven't tested locally.

lib/storage/base.js Outdated Show resolved Hide resolved
lib/base-compiler.ts Outdated Show resolved Hide resolved
@mattgodbolt mattgodbolt merged commit 749319f into main Dec 28, 2022
@mattgodbolt mattgodbolt deleted the mg/bumpings2 branch December 28, 2022 17:42
mattgodbolt added a commit that referenced this pull request Jan 4, 2023
- latest sentry, tar-stream, which, some yamljs versions
- latest eslint-* stuff
- latest webpack manifest
- Applies all the automatic fixes for newer lint rules
- Bump the webpack version

applies new tslint stuff
mattgodbolt added a commit that referenced this pull request Jan 24, 2023
- latest sentry, tar-stream, which, some yamljs versions
- latest eslint-* stuff
- latest webpack manifest
- Applies all the automatic fixes for newer lint rules
- Bump the webpack version

applies new tslint stuff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants