New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly more controversial bumpings #4503
Conversation
- latest sentry, tar-stream, which, yamljs versions - latest css minimizer - latest eslint-* stuff - latest webpack manifest - Applies all the automatic fixes for newer lint rules
@@ -1200,7 +1199,7 @@ | |||
return [{text: 'Failed to run compiler to get Rust MIR'}]; | |||
} | |||
if (await utils.fileExists(mirPath)) { | |||
const content = await fs.readFile(mirPath, 'utf-8'); | |||
const content = await fs.readFile(mirPath, 'utf8'); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
@@ -2497,7 +2496,7 @@ | |||
output.currentPassOutput = ''; | |||
|
|||
if (dumpFileName && (await fs.pathExists(dumpFileName))) | |||
output.currentPassOutput = await fs.readFile(dumpFileName, 'utf-8'); | |||
output.currentPassOutput = await fs.readFile(dumpFileName, 'utf8'); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me at face value. I haven't tested locally.
- latest sentry, tar-stream, which, some yamljs versions - latest eslint-* stuff - latest webpack manifest - Applies all the automatic fixes for newer lint rules - Bump the webpack version applies new tslint stuff
- latest sentry, tar-stream, which, some yamljs versions - latest eslint-* stuff - latest webpack manifest - Applies all the automatic fixes for newer lint rules - Bump the webpack version applies new tslint stuff
libs and ts tooling update