[WIP] manyclangs: Add preliminary support for compiler libraries #4600
Conversation
|
This is extremelly cool. Wow. Great job with this :) |
|
I wonder if the name compiler-library is maybe confusing with normal libraries. Maybe compiler-repository would be more suitable? |
|
Hi @veselink1 ! Lovely to see this. Sorry you're seeing so many conflicts : unfortunately it became high priority to move everything to typescript (which has been our primary focus this year so far). We're nearly there now, and hopefully it won't be too painful. Looking great so far: will skim over the PR as-is shortly |
veselink1
force-pushed
the
main
branch
2 times, most recently
from
f707eac
to
06e6207
Compare
Compiler repositories are compiler toolchains which provide access to a large number of compiler revisions. A compiler repository is any instance of `ICompiler` which has `isCompilerLibrary` set to `true`, which means it also implements the `ICompilerRepository` interface. If a compiler repository is selected via the UI, a new "revision picker" is displayed, which provides search and pagination of the available compiler revisions, in addition to prev/next buttons to browser through revisions one-by-one. Pagination is implemented by the `/compilerRevision/:compiler/search` endpoint, which accepts an optional query, offset and limit. This change also lays the groundwork for including manyclangs as a compiler repository. TODO: - Implement getRevisions() for manyclangs (via `elfshaker list` or similar) - Handle arguments for compiler repository in complie() (we likely don'ot need to extend the command line as we currently do) and make it call manyclangs-run or some custom wrapper
|
Hey @veselink1 do let us know if you need a hand; this seems to have fallen by the wayside. I spoke with @pwaller the other day and he implied that you might have been blocked on us: let me know if that's the case please! |
|
Hey @mattgodbolt, sorry for taking so long to reply. The UI portion of the work is pretty much complete. It provides a revision picker and a way for the backend to expose manyclangs-style compiler repositories through it. I was pretty much hoping either you or someone more familiar could take care of the remaining two tasks - exposing the list of revisions to the UI and doing the actual compilation :) |
|
Thanks @veselink1 ! Understood. I think we're all suffering from "not enough time". I know I'm drowning just trying to keep the bitrot/entropy in check... |
This PR is the first step of manyclangs integration into CE and introduces some UI and code-behind changes.
In order to support something like manyclangs, which packages thousands of revisions of clang+some LLVM tools, I've added the concept of compiler libraries.
A compiler library is any instance of
CompilerBasewhich hasisCompilerLibraryset totrueand exposes agetRevisionsmethod, listing all the available revisions. Likely not the prettiest way to integrate something like this, happy to hear feedback.If a compiler library is selected via the UI, a new "revision picker" is displayed, which provides search and pagination of the available compiler revisions, in addition to prev/next buttons to browser through revisions one-by-one.
Pagination is implemented by the
/compilerLibrary/:compiler/searchendpoint, which accepts an optional query, offset and limit.This change also lays the groundwork for including manyclangs as a compiler library. Currently, I've made the compiler definition bind to /usr/bin/yes, because I'm not sure how we would want to process the compiler args in the backend.
elfshaker listor similar)2023-01-15.14-27-59.mp4