Add webassembly language #6429
Open
Add webassembly language #6429
+868
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonso360
commented
May 4, 2024
Comment on lines
+2
to
+3
| objdumper=llvm-objdump | ||
| objdumperType=llvm |
There was a problem hiding this comment.
I used llvm-objdump here because wasmtime supports a --target=<triple> parameter that cross-compiles WASM modules for other architectures. The problem is that when using objdump it then can't disassemble the resulting file. I'm not sure if there is a better solution to handle these cases
RubenRBS
reviewed
May 4, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The previous regex had a exponential backtracking issue under some inputs.
|
I'd love to have Wasmer supported as well! Let me know if we can help with that :) |
|
Awesome! I already have a WIP patch locally adding wasmer! I was waiting to get this merged in before proposing that. |
|
|
||
| escapes: /^\\(?:["'\\bfnrt]|x[0-9A-Fa-f]{1,4}|u[0-9A-Fa-f]{4}|U[0-9A-Fa-f]{8})/, | ||
|
|
||
| qualifiedSymbols: /^(?:[^\\/[\]\d\s"#'(),;@^`{}~][^\\[\]\s"(),;@^`{}~]*)*(?=[\\[\]\s"(),;@^`{}~]|$)/, |
Check failure
Code scanning / CodeQL
Inefficient regular expression High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR adds support for the Webassembly Text Language (#1871). Currently it only supports the wasmtime compiler, but it should be possible to add others (i.e. v8 / wasmer / etc...).
It looks like the monaco does not support the WAT language, so I've added a simple mode for it, that is mostly copied from the clojure mode with some changes. From what I've tested it seems to work reasonably well.