Add aarch64prod #1270
Add aarch64prod #1270
Conversation
| predefined_metric_specification { | ||
| predefined_metric_type = "ASGAverageCPUUtilization" | ||
| } | ||
| target_value = 50.0 |
There was a problem hiding this comment.
r7g.medium only has 1 vCpu, so I suspect 50% will trigger more scaling than we want
| version = "$Latest" | ||
| } | ||
| override { | ||
| instance_type = "r7g.medium" |
There was a problem hiding this comment.
https://instances.vantage.sh/aws/ec2/r7g.medium
I built the packer image with a Graviton3 cpu, I don't really know if we can also add Grav2 to this mix
But if possible we could also add https://instances.vantage.sh/aws/ec2/c6g.xlarge
But it might just be better to stick to 1 type for now
| @@ -264,3 +264,35 @@ resource "aws_alb_listener_rule" "compiler-explorer-alb-listen-https-stats" { | |||
| } | |||
| listener_arn = aws_alb_listener.compiler-explorer-alb-listen-https.arn | |||
| } | |||
|
|
|||
| resource "aws_alb_listener_rule" "compiler-explorer-alb-listen-http-aarch64prod" { | |||
There was a problem hiding this comment.
I need to see if the http ones are needed any more (or the https ones), basically if the ALB is hitting the HTTPS all the time only then we could kill off half these.
| @@ -0,0 +1,141 @@ | |||
| resource "aws_autoscaling_group" "prod-mixed" { | |||
There was a problem hiding this comment.
Thank you for busting these out to separate files.
| } | ||
| } | ||
|
|
||
| enabled_metrics = [ |
There was a problem hiding this comment.
We probably should make this a local. and use it throughout to reduce copy pastey. I'm pretty sure that "just works" in terraform but also wouldn't be too surprised if there were gremlins.
| @@ -3,12 +3,14 @@ locals { | |||
| staging_image_id = "ami-0dac25c567aa57e61" | |||
| beta_image_id = "ami-0dac25c567aa57e61" | |||
| gpu_image_id = "ami-05e1d61b3348d349f" | |||
| aarch64prod_image_id = "ami-0575a3cc115c9f3ac" | |||
There was a problem hiding this comment.
Can you add the packer that makes this to the Makefile etc too please?
There was a problem hiding this comment.
I added that to main already with 1e6e847 - please do take a look at it and see if I did something daft
(Based on #1269)
Adds Aarch64 prod environment
Will also need a staging environment
Untested