Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump requests from 2.29.0 to 2.32.0 in /lambda #1301

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Bump requests from 2.29.0 to 2.32.0 in /lambda #1301

wants to merge 3 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 14, 2024

Bumps requests from 2.29.0 to 2.31.0.

Release notes

Sourced from requests's releases.

v2.31.0

2.31.0 (2023-05-22)

Security

  • Versions of Requests between v2.3.0 and v2.30.0 are vulnerable to potential forwarding of Proxy-Authorization headers to destination servers when following HTTPS redirects.

    When proxies are defined with user info (https://user:pass@proxy:8080), Requests will construct a Proxy-Authorization header that is attached to the request to authenticate with the proxy.

    In cases where Requests receives a redirect response, it previously reattached the Proxy-Authorization header incorrectly, resulting in the value being sent through the tunneled connection to the destination server. Users who rely on defining their proxy credentials in the URL are strongly encouraged to upgrade to Requests 2.31.0+ to prevent unintentional leakage and rotate their proxy credentials once the change has been fully deployed.

    Users who do not use a proxy or do not supply their proxy credentials through the user information portion of their proxy URL are not subject to this vulnerability.

    Full details can be read in our Github Security Advisory and CVE-2023-32681.

v2.30.0

2.30.0 (2023-05-03)

Dependencies

Changelog

Sourced from requests's changelog.

2.31.0 (2023-05-22)

Security

  • Versions of Requests between v2.3.0 and v2.30.0 are vulnerable to potential forwarding of Proxy-Authorization headers to destination servers when following HTTPS redirects.

    When proxies are defined with user info (https://user:pass@proxy:8080), Requests will construct a Proxy-Authorization header that is attached to the request to authenticate with the proxy.

    In cases where Requests receives a redirect response, it previously reattached the Proxy-Authorization header incorrectly, resulting in the value being sent through the tunneled connection to the destination server. Users who rely on defining their proxy credentials in the URL are strongly encouraged to upgrade to Requests 2.31.0+ to prevent unintentional leakage and rotate their proxy credentials once the change has been fully deployed.

    Users who do not use a proxy or do not supply their proxy credentials through the user information portion of their proxy URL are not subject to this vulnerability.

    Full details can be read in our Github Security Advisory and CVE-2023-32681.

2.30.0 (2023-05-03)

Dependencies

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot
Bump requests from 2.29.0 to 2.31.0 in /lambda
a8b5281 
Bumps [requests](https://github.com/psf/requests) from 2.29.0 to 2.31.0.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.29.0...v2.31.0)

---
updated-dependencies:
- dependency-name: requests
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels May 14, 2024
@mattgodbolt
Copy link
Member

Last time I considered doing something like this I think @partouf you suggested it might break things? I forget 😊

If it's ok though I'll merge then build/update the lambda. Or do the lambada?

@partouf
Copy link
Contributor

partouf commented May 14, 2024

no definitely dont merge, this will break lambda's, unless aws has updated their environment

@mattgodbolt mattgodbolt marked this pull request as draft May 14, 2024 01:42
@mattgodbolt
Copy link
Member

Got it; thanks. I'll google about and see if I can prove out how to tell if this is OK now

@partouf
Copy link
Contributor

partouf commented May 14, 2024

So the reason is that requests 2.30 uses urllib3, which in turn changes some SSL stuff.

This is one of the possible errors, but we got a different one back when I was testing it:
https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html#importerror-cannot-import-name-default-ciphers-from-urllib3-util-ssl

@partouf
Copy link
Contributor

partouf commented May 14, 2024

I think we got this one https://repost.aws/questions/QUPrAJ9DjyRlWMMe5r_yS6ug/lambdas-using-urllib3-2-0-0-fails-in-python-3-8-runtime

@partouf
Copy link
Contributor

partouf commented May 14, 2024

Looking at aws/aws-lambda-base-images#118 and https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html to see if maybe we can use newer python version environments to solve this

@partouf
Copy link
Contributor

partouf commented May 14, 2024 •
edited

"Python 3.12" uses "Amazon Linux 2023" instead of "Amazon Linux 2"
https://docs.aws.amazon.com/linux/al2023/ug/compare-with-al2.html

Uses openssl 3 by default instead of v1

So that might work

@partouf partouf mentioned this pull request May 29, 2024
Closed
@partouf partouf changed the title Bump requests from 2.29.0 to 2.31.0 in /lambda Bump requests from 2.29.0 to 2.32.0 in /lambda May 29, 2024
@partouf
Copy link
Contributor

partouf commented May 29, 2024

https://pypi.org/project/requests/#history

Latest is 2.32.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattgodbolt @partouf