"This is now live" automatic notifications #715
Conversation
|
|
||
|
|
||
| def get_linked_pr(commit: str, token: str) -> dict: | ||
| pr = get(f"repos/{OWNER_REPO}/commits/{commit}/pulls", token=token) |
There was a problem hiding this comment.
Technically this is should be a paginated get, but if we find a PR with 30 or more linked issues.. Wow
There was a problem hiding this comment.
Also, the GraphQL query only lists the first 10, so there won't be more than that in the response, which fit in a single page
There was a problem hiding this comment.
Can graphql query on label status? I think that finding results that haven't been tagged live might be safer and easier on humans to find if it goes wrong, instead of having to look inside all the comments inside each PR
|
|
||
|
|
||
| def get_linked_pr(commit: str, token: str) -> dict: | ||
| pr = get(f"repos/{OWNER_REPO}/commits/{commit}/pulls", token=token) |
There was a problem hiding this comment.
Also, the GraphQL query only lists the first 10, so there won't be more than that in the response, which fit in a single page
|
|
||
|
|
||
| def get_linked_pr(commit: str, token: str) -> dict: | ||
| pr = get(f"repos/{OWNER_REPO}/commits/{commit}/pulls", token=token) |
There was a problem hiding this comment.
Can graphql query on label status? I think that finding results that haven't been tagged live might be safer and easier on humans to find if it goes wrong, instead of having to look inside all the comments inside each PR
RubenRBS
force-pushed
the
rr/now-live-notify
branch
from
a133c51
to
64b131b
Compare
Addresses PR reviews
RubenRBS
force-pushed
the
rr/now-live-notify
branch
from
e49457d
to
182b7cd
Compare
|
The failing test comes from the branch being a bit outdated, nothing to worry about |
|
Just ran |
In case of error, the program will break either way, but we make sure we hide the token secret
|
This could be awesome. Any chance of resurrecting this @RubenRBS ? |
There is still some work to be done, but the gist of it is:
ce builds set_current ...store the oldest non-notified commit, skipping if something is already storedce environment refresh(and laterce instances restart) get the currently deployed version, and:This would need a new ssm in aws, and I need to test it in case where no key exists (Which should be the case of env refreshes for the same version!)