Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composer error when git config safe.bareRepository is set to explicit #11969

Merged

Conversation

krzysztof-ciszewski
Copy link
Contributor

Fixes #11855

@krzysztof-ciszewski krzysztof-ciszewski marked this pull request as draft May 9, 2024 15:59
@krzysztof-ciszewski
Copy link
Contributor Author

krzysztof-ciszewski commented May 11, 2024

@Seldaek could you please mark this PR as ready to review? I think php 8.4 tests are allowed to fail right?
Sorry, figured it out myself.

@krzysztof-ciszewski krzysztof-ciszewski marked this pull request as ready for review May 11, 2024 08:02
@Seldaek
Copy link
Member

Seldaek commented May 27, 2024

Thanks. I am not a huge fan of doing this git specific handling in the ProcessExecutor class tbh, but I can also see it does simplify stuff a bit.. and it's all private so can still extract it without BC issues later if needed.

@Seldaek Seldaek merged commit 81b121b into composer:main May 27, 2024
17 of 20 checks passed
@Seldaek Seldaek added this to the 2.7 milestone May 27, 2024
@Seldaek Seldaek added the Bug label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for safe.bareRepository explicit Git config
2 participants