Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Ring with the experimental implmenetation #1408

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Replace Ring with the experimental implmenetation #1408

wants to merge 3 commits into from

Conversation

adithyaov
Copy link
Member 

Generating reports for Prelude.Serial...
Prelude.Serial(cpuTime)
Benchmark                                                                             default(0)(ms) default(1) - default(0)(%)
------------------------------------------------------------------------------------- -------------- --------------------------
All.Prelude.Serial/o-1-space.split.S.splitOnSeq 100k long pattern                             263.06                     +17.60
All.Prelude.Serial/o-1-space.split.S.splitOnSeq "catcatcatcatcat" FL.drain                    257.32                     +14.48
All.Prelude.Serial/o-1-space.split.S.splitOnSeq "abcdefghi" FL.drain                          259.26                     +13.36
All.Prelude.Serial/o-1-space.split.S.splitOnSeq "abcdefgh" FL.drain                           139.17                     +13.13
All.Prelude.Serial/o-1-space.split.S.splitOnSeq "abcdefghijklmnopqrstuvwxyz" FL.drain         258.78                     +13.02
All.Prelude.Serial/o-1-space.split.S.splitOnSeq "\r\n" FL.drain                               109.71                      +6.98
All.Prelude.Serial/o-1-space.split.S.splitOnSeq "\n" FL.drain                                 140.03                      +2.54
All.Prelude.Serial/o-1-space.split.S.splitOnSeq "" FL.drain                                    47.94                      -2.45
All.Prelude.Serial/o-1-space.split.S.splitOnSeq "aaaa" FL.drain                               140.05                      -4.54
All.Prelude.Serial/o-1-space.split.S.splitOnSeq "a" FL.drain                                  124.01                     -12.03
All.Prelude.Serial/o-1-space.split.S.splitOnSeq "aa" FL.drain                                 137.54                     -27.76

adithyaov
adithyaov commented Jan 3, 2022
View reviewed changes
src/Streamly/Internal/Data/Ring/Foreign.hs
{ ringContents# :: MutableByteArray# RealWorld
, ringNext :: {-# UNPACK #-} !Int -- The index pointing to the oldest
-- element.
, ringLength :: {-# UNPACK #-} !Int -- The true length of the ring.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be moved out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Computing this all the time will be costly though.

@harendra-kumar harendra-kumar marked this pull request as draft July 5, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adithyaov