add BigNumber comment; reduce scale of negative comet base balance test

compound-finance · Apr 22, 2022 · 209e42c · 209e42c
1 parent dbc3021
commit 209e42c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/scenario/ConstraintScenario.ts b/scenario/ConstraintScenario.ts
@@ -66,7 +66,7 @@ scenario(
     expectApproximately(
       await albert.getCometBaseBalance(),
       -100n * scale,
-      (scale / 1000n) // .001 units of asset
+      (scale / 1000000n) // .000001 units of asset
     );
   }
 );

diff --git a/scenario/constraints/CometBalanceConstraint.ts b/scenario/constraints/CometBalanceConstraint.ts
@@ -137,6 +137,8 @@ export class CometBalanceConstraint<T extends CometContext, R extends Requiremen
           const amount = parseAmount(rawAmount);
           const decimals = await asset.token.decimals();
           const baseToken = await comet.baseToken();
+          // Chai matchers (like `.to.be.at.most()`) only work for numbers and
+          // BigNumbers, so we convert from BigInt to BigNumber
           let actualBalance: BigNumber;
           let expectedBalance: BigNumber;
           if (asset.address === baseToken) {