[ChainSecurity 5.9] Least invasive version of updated interest indices for balances #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-silver
force-pushed
the
jflatow/accrue
branch
from
88ae18c
to
af59095
Compare
|
I think this is ready to merge now; I'm going to remove |
|
I can't approve since I created but 👍 |
kevincheng96
changed the title
Sounds good, just making a note here that we should remember to link that one before merging this one so we don't forget |
scott-silver
force-pushed
the
jflatow/accrue
branch
from
af59095
to
7be8007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the ERC-20 balance functions (
totalSupply,balanceOf) so they can use updated interest indices, as well asborrowBalanceOf. We keepbaseBalanceOfusing the cached indices since that would require deeper changes to thepresentValuefunction and all its call sites.Currently breaking 2 accrue tests, and we should add a few to cover changes.