Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] multiple spans per error #101

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

[WIP] multiple spans per error #101

wants to merge 13 commits into from

Conversation

reiner-dolp
Copy link
Contributor

@reiner-dolp reiner-dolp commented Nov 17, 2018 •
edited

  • introduces multiple spans per error
  • introduces annotations for spans in addition to the error message
  • uses Unicode Box-Drawing Characters instead of ASCII chars to Draw errors

@reiner-dolp
Copy link
Contributor Author

image
image
image

@reiner-dolp
Copy link
Contributor Author

reiner-dolp commented Nov 17, 2018 •
edited

This currently has a bug causing a panic for multilinespans with empty lines. Do not merge!

@reiner-dolp reiner-dolp changed the title multiple spans per error WIP: multiple spans per error Nov 17, 2018
@reiner-dolp
Copy link
Contributor Author

image

image

way to much spans:
image

@reiner-dolp
Copy link
Contributor Author

Actual output
image

reiner-dolp
reiner-dolp commented Nov 18, 2018
View reviewed changes
compiler-cli/integration-tests/lexer/ascii_control_character.invalid.mj.stderr
1 | /* Now comes ASCII \x1b (ESC) */ {\x1b}
| ^^^^^^
│
1 │ /* Now comes ASCII \x1b (ESC) */ {\x1b}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong

reiner-dolp
reiner-dolp commented Nov 18, 2018
View reviewed changes
compiler-cli/integration-tests/lexer/weird_whitespace.invalid.mj.stderr
| ^^^^^^
│
2 │ {\x0b}{\x0c}
│ ^
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong

reiner-dolp
reiner-dolp commented Nov 18, 2018
View reviewed changes
compiler-cli/integration-tests/parser/weird_whitespace.invalid.mj.stderr
| ^^^^^^
│
2 │ {\x0b}{\x0c}
│ ^
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong

@reiner-dolp reiner-dolp changed the title WIP: multiple spans per error [WIP] multiple spans per error Jan 4, 2019
@reiner-dolp reiner-dolp added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Jan 4, 2019
@problame problame added this to Todo !(optimization OR backend) in Endspurt Feb 4, 2019
@flip1995 flip1995 mentioned this pull request Feb 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
Endspurt
  
General Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@reiner-dolp