Implemented debugger helpers for debugging in vscode with visualizer extensions and gdb #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extensions and gdb.
reiner-dolp
reviewed
Jan 22, 2019
| @@ -63,36 +63,108 @@ use std::{ | |||
| thread::{self, JoinHandle}, | |||
| }; | |||
|
|
|||
| #[cfg(feature = "debugger_gui")] | |||
| #[cfg(any(feature = "debugger_gui", feature = "debugger_vscode"))] | |||
There was a problem hiding this comment.
since both breakpoint implementations have nothing in common, why not make a seprate #[cfg(feature = "debugger_vscode")] implementation?
There was a problem hiding this comment.
They have a lot in common. This way, you can use the debugger server and I can use the debugger visualizer in vs code without needing to change anything or having code duplicates.
There was a problem hiding this comment.
What I mean is this:
#[cfg(feature = "debugger_gui")]
macro_rules! breakpoint {
// all the stuff from the if-truee-branches in the current impl
}
#[cfg(feature = "debugger_vscode")]
macro_rules! breakpoint {
// all the stuff from the else-branches in the current impl
}
reiner-dolp
reviewed
Jan 22, 2019
|
This fails because of clippy errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.