CMake Conan 2.0 compatibility #13739

System-Arch · 2022-10-25T03:27:09Z

Specify library name and version: cmake/3.24.2

Updated conanfile.py and test_package/conanfile.py to work with Conan 2.0.0-beta4 (Resolves #13613)

Changes involve leveraging Conan 2.0 generators and other syntactic changes

Tested on Linux (including bootstrap option) and Windows

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

Note that many of the test files packaged with the CMake source code trigger conan-center hook failures due to missing trailing endlines and missing CMake minimum version declarations.

recipes/cmake/3.x.x/conanfile.py

recipes/cmake/3.x.x/test_package/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

prince-chrismc · 2022-10-31T18:47:46Z

This counts towards #12888 🚀

ericLemanissierBot · 2022-11-02T09:42:51Z

I detected other pull requests that are modifying cmake/3.x.x recipe:

cmake/3.25.1 #15079

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

recipes/cmake/3.x.x/conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

recipes/cmake/3.x.x/conanfile.py

prince-chrismc

This looks really good there's a lot of good work, I dont see any blockers (nor any issue for that matter) I think this good unless there's a blockers.

Check from me!

recipes/cmake/3.x.x/test_package/conanfile.py

jellespijker

LGTM

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

conan-center-bot · 2023-01-11T15:55:10Z

Conan v1 pipeline

All green in build 40 (182c7d474ad40462e032d264c75de8aa64bf0da9):

cmake/3.20.6@:
All packages built successfully! (All logs)
cmake/3.19.8@:
All packages built successfully! (All logs)
cmake/3.21.7@:
All packages built successfully! (All logs)
cmake/3.22.6@:
All packages built successfully! (All logs)
cmake/3.24.3@:
All packages built successfully! (All logs)
cmake/3.25.0@:
All packages built successfully! (All logs)
cmake/3.23.5@:
All packages built successfully! (All logs)
cmake/3.25.1@:
All packages built successfully! (All logs)

jcar87

LGTM!
Thanks so much @System-Arch, on top of Conan 2.0 compatibility this receives a much needed improvement. Thanks to all reviewers as well!

* CMake Conan 2.0 compatibility * Fix lint errors * Avoid lint error with Conan 2.0 argument name * Avoid lint error with Conan 2.0 argument name * Removed unused imports * Handle Conan version disparities * Use basic_layout with Autotools Co-authored-by: Uilian Ries <uilianries@gmail.com> * Call AutotoolsDeps generate Co-authored-by: Uilian Ries <uilianries@gmail.com> * Call CMakeDeps generate Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update imports per suggestioned changes * Removed extra space * Remove extraneous items * Determine require_version in a version-agnostic manner * Use Conan 1.53 * Handle @ in ref * Fix lint errors * Bigger hammer * Remove PATH addition in package_id Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Use validate_build instead of validate * Moved Mac x86 check to validate() method. * Bump openssl version Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Add blank line to trigger CI build * Eliminate use of validate_build() * Restore use of validate_build() * Removed blank line to trigger CI * Add blank line to trigger CI * Added boostrap options and removed unneeded env. vars * Deal with Conan 1.x vs 2.0 inconsistencies * Fixed lint issue * Placate linter * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Use save & load for bootstrap args; Use tool_requires in test packages * Eliminate use of validate_build; Add more settings to test recipes * Set PATH in package_info() for v1.x; Lower req. ver. to 1.50 * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Added AutotoolsDeps generator; Eliminated can_run() from tests * Correct msvc version Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Use f-strings * Replace VirtualRunEnv with VirtualBuildEnv Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

CMake Conan 2.0 compatibility

8014395

conan-center-bot added the Failed label Oct 25, 2022

This comment has been minimized.

Sign in to view

Fix lint errors

3279e24

conan-center-bot added Unexpected Error and removed Failed labels Oct 25, 2022

This comment has been minimized.

Sign in to view

Avoid lint error with Conan 2.0 argument name

312df47

conan-center-bot added Failed and removed Unexpected Error labels Oct 25, 2022

This comment has been minimized.

Sign in to view

Avoid lint error with Conan 2.0 argument name

3498d3f

This comment has been minimized.

Sign in to view

Removed unused imports

bb9383d

This comment has been minimized.

Sign in to view

Handle Conan version disparities

31ab1a3

uilianries reviewed Oct 25, 2022

View reviewed changes

System-Arch and others added 5 commits October 25, 2022 17:41

Use basic_layout with Autotools

05f13da

Co-authored-by: Uilian Ries <uilianries@gmail.com>

Call AutotoolsDeps generate

5769d2c

Co-authored-by: Uilian Ries <uilianries@gmail.com>

Call CMakeDeps generate

b00e0bd

Co-authored-by: Uilian Ries <uilianries@gmail.com>

Update imports per suggestioned changes

520b6e1

Removed extra space

4be0900

This comment has been minimized.

Sign in to view

Remove extraneous items

8a86742

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Oct 31, 2022

Conan 2.0 Migration Effort #12888

Closed

This was referenced Nov 2, 2022

[service] Potentially conflicting recipes #3571

Open

cmake: bump openssl #13954

Merged

System-Arch requested review from prince-chrismc and jcar87 and removed request for prince-chrismc and jcar87 December 9, 2022 16:44

czoido previously approved these changes Dec 12, 2022

View reviewed changes

czoido mentioned this pull request Dec 12, 2022

Add cmake czoido/conan-center-index#27

Merged

SpaceIm reviewed Dec 12, 2022

View reviewed changes

recipes/cmake/3.x.x/conanfile.py Outdated Show resolved Hide resolved

Correct msvc version

3bf716f

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

System-Arch dismissed czoido’s stale review via 3bf716f December 12, 2022 13:29

ericriff reviewed Dec 12, 2022

View reviewed changes

recipes/cmake/3.x.x/conanfile.py Show resolved Hide resolved

ericriff reviewed Dec 12, 2022

View reviewed changes

recipes/cmake/3.x.x/conanfile.py Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Use f-strings

8fa91ae

This comment has been minimized.

Sign in to view

conan-center-bot requested a review from franramirez688 December 20, 2022 12:01

ericLemanissierBot mentioned this pull request Jan 3, 2023

cmake/3.25.1 #15079

Merged

3 tasks

prince-chrismc previously approved these changes Jan 4, 2023

View reviewed changes

SpaceIm suggested changes Jan 4, 2023

View reviewed changes

recipes/cmake/3.x.x/test_package/conanfile.py Outdated Show resolved Hide resolved

conan-center-bot requested a review from jcar87 January 6, 2023 12:02

jellespijker previously approved these changes Jan 7, 2023

View reviewed changes

Replace VirtualRunEnv with VirtualBuildEnv

182c7d4

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

System-Arch dismissed stale reviews from jellespijker and prince-chrismc via 182c7d4 January 11, 2023 14:02

prince-chrismc approved these changes Jan 14, 2023

View reviewed changes

jcar87 approved these changes Jan 14, 2023

View reviewed changes

conan-center-bot merged commit a2bd965 into conan-io:master Jan 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CMake Conan 2.0 compatibility #13739

CMake Conan 2.0 compatibility #13739

System-Arch commented Oct 25, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

prince-chrismc commented Oct 31, 2022

ericLemanissierBot commented Nov 2, 2022 •

edited

This comment has been minimized.

This comment has been minimized.

prince-chrismc left a comment

jellespijker left a comment

conan-center-bot commented Jan 11, 2023

jcar87 left a comment

CMake Conan 2.0 compatibility #13739

CMake Conan 2.0 compatibility #13739

Conversation

System-Arch commented Oct 25, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

prince-chrismc commented Oct 31, 2022

ericLemanissierBot commented Nov 2, 2022 • edited

This comment has been minimized.

This comment has been minimized.

prince-chrismc left a comment

Choose a reason for hiding this comment

jellespijker left a comment

Choose a reason for hiding this comment

conan-center-bot commented Jan 11, 2023

Conan v1 pipeline

jcar87 left a comment

Choose a reason for hiding this comment

ericLemanissierBot commented Nov 2, 2022 •

edited