add lely-core/2.3.2 #15151
add lely-core/2.3.2 #15151
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
uyha
requested review from
uilianries and
RubenRBS
and removed request for
RubenRBS and
uilianries
|
@uilianries @RubenRBS @prince-chrismc I'm really sorry for tagging and pushing, but I need to use this library in a project and would like to import it through Conan, and I think this package is ready to be merged in. Could you review it again? |
You can check my bot prince-chrismc/conan-center-index-pending-review#1 so learn about the status of all PRs there are fun graphs at the bottom it's currently taking ~16 days for PRs to merge so you'll need to be patient as we have a huge backlog from the holidays |
I checked that, but I became anxious (due to no review, and pressure to use it) so I am really sorry again for this. |
|
No worries, we understand that it's hard when you feel like your PR gets ignored, but as Chris said, it's not the case! We're just running a bit behind due to the holidays :) |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 37 (
|
* add lely * fix lint error * add description * add patch information * add patch_source * change name from lely to lely-core * fix url and homepage attributes * add test for conan v1 * link thread library in test package * include LICENSE file and remove pkgconfig and .la files * switch to explicit typing to satisfy C++11 construction * fix conanfile.py for conan v1 and fix test * specify C++ version when compiling test * fix conanfile.py for test package conan v1 * correct path of executable * remove fPIC when building shared library * specify system libraries * use rm_safe instead of del * include conanbuildinfo.cmake * correct executable path * fix v2 test * try different way of importing * force compile with gcc only * fix typo and move comment into the error message * change license to SPDX short-name form * clarify error messages * use configure_args AutotoolsToolchain instead of passing them as an argument * move configuring arguments to generate method * reuse test_package's CMake script in test_v1_package * add version 2.3.2 * remove version 2.3.1 * remove unnecessary Threads::Threads linking
Specify library name and version: lely-core/2.3.1
lely-coreis a library for interacting with CANopen and it is not available on Conan Center yet, so I want to have it available there.