New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osqp: add recipe #16469

Merged

conan-center-bot merged 1 commit into conan-io:master from billyzheli:master

Mar 23, 2023

Contributor

billyzheli commented Mar 8, 2023

Specify library name and version: osqp/0.6.2

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant commented Mar 8, 2023 •

edited

All committers have signed the CLA.

prince-chrismc mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the User-approval pending label

This comment has been minimized.

Sign in to view

billyzheli force-pushed the master branch from 93ddc37 to 538b329 Compare

March 9, 2023 14:14

This comment has been minimized.

Sign in to view

billyzheli force-pushed the master branch from 538b329 to 481a3da Compare

March 10, 2023 14:27

conan-center-bot added Failed and removed User-approval pending labels

This comment has been minimized.

Sign in to view

billyzheli force-pushed the master branch from 481a3da to 4385531 Compare

March 13, 2023 19:14

This comment has been minimized.

Sign in to view

billyzheli force-pushed the master branch from 4385531 to af74898 Compare

March 13, 2023 22:38

conan-center-bot removed the Failed label

This comment has been minimized.

Sign in to view

StellaSmith suggested changes

View reviewed changes

recipes/osqp/all/conanfile.py Outdated Show resolved Hide resolved

recipes/osqp/all/conanfile.py Show resolved Hide resolved


          osqp: add recipe

billyzheli force-pushed the master branch from af74898 to 8513491 Compare

March 19, 2023 17:19

Collaborator

conan-center-bot commented Mar 19, 2023

Conan v1 pipeline ✔️

All green in build 6 (8513491667eea99dba665a4b7b7302cf58a8d499):

osqp/0.6.2@:
All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 6 (8513491667eea99dba665a4b7b7302cf58a8d499):

osqp/0.6.2@:
All packages built successfully! (All logs)

billyzheli requested a review from StellaSmith

March 20, 2023 19:58

conan-center-bot requested review from danimtb and removed request for StellaSmith

March 21, 2023 12:01

Contributor Author

billyzheli commented Mar 21, 2023

Hi @StellaSmith, I wonder why this PR is not listed in Pull Requests Ready to be Reviewed #1. It used to be listed there.

Contributor

StellaSmith commented Mar 21, 2023

Because you don't comply with two of the selection criteria anymore.
Also, please do not force push, makes reviewing harder. Your commits will be squashed into a single one once when the bots merges the pull request.

StellaSmith approved these changes

View reviewed changes

danimtb approved these changes

View reviewed changes

conan-center-bot merged commit fbca447 into conan-io:master

0xFireWolf pushed a commit to 0xFireWolf/conan-center-index that referenced this pull request


          (conan-io#16469) osqp: add recipe

1f0f7d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment