Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdlog: make sure libdirs is empty when header_only=True #19283

Merged
merged 1 commit into from Aug 22, 2023

Conversation

gegles
Copy link
Contributor

@gegles gegles commented Aug 19, 2023

Specify library name and version: spdlog/1.12.0

This PR removes the following warning (on macOS) when the library is used in header_only=True mode:

ld: warning: directory not found for option '-L/Users/gegles/.conan2/p/b/spdlo6818b9a6a2366/p/lib'

@ericLemanissierBot
Copy link

I detected other pull requests that are modifying spdlog/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (b5d61a81c8374ab8733d20247e12deee512ce162):

  • spdlog/1.10.0:
    All packages built successfully! (All logs)

  • spdlog/1.11.0:
    All packages built successfully! (All logs)

  • spdlog/1.9.2:
    All packages built successfully! (All logs)

  • spdlog/1.9.1:
    All packages built successfully! (All logs)

  • spdlog/1.8.5:
    All packages built successfully! (All logs)

  • spdlog/1.12.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 2 (b5d61a81c8374ab8733d20247e12deee512ce162):

  • spdlog/1.12.0:
    All packages built successfully! (All logs)

  • spdlog/1.11.0:
    All packages built successfully! (All logs)

  • spdlog/1.10.0:
    All packages built successfully! (All logs)

  • spdlog/1.9.1:
    All packages built successfully! (All logs)

  • spdlog/1.9.2:
    All packages built successfully! (All logs)

  • spdlog/1.8.5:
    All packages built successfully! (All logs)

@gegles
Copy link
Contributor Author

gegles commented Aug 21, 2023

FYI @RubenRBS, thx! 🙏🏻

@RubenRBS RubenRBS self-assigned this Aug 21, 2023
@gegles
Copy link
Contributor Author

gegles commented Aug 22, 2023

@prince-chrismc? Anybody? Thanks!!

@prince-chrismc
Copy link
Contributor

@gegles You need to be more patient :) This PR is already approved and you can see the bot has been very hard at work (running smoothly as melted butter)

image

@prince-chrismc
Copy link
Contributor

I made prince-chrismc/conan-center-index-pending-review#1 because the bot merge rules do not match GitHub's UI and you can check on the status of all the pull requests

You can see you're in the "Ready to Merge" Section

image

@gegles
Copy link
Contributor Author

gegles commented Aug 22, 2023

@gegles You need to be more patient :) This PR is already approved and you can see the bot has been very hard at work (running smoothly as melted butter)

@prince-chrismc,

Ah, ah, patience is not my strong suite, but I'll try harder 😉.

Thanks for the link and info... I was just making sure things were progressing forward and wasn't quite sure where in the process things were. Now I can, thanks!

You guys are doing a phenomenal job! I am very impress by the rigor and quality of this whole process and the Conan community! Thanks for all your hard work!

Cheers. G.

@prince-chrismc
Copy link
Contributor

Thanks for the link and info... I was just making sure things were progressing forward and wasn't quite sure where in the process things were. Now I can, thanks!

This has been a challenge for a long time, I used to be a very active contributor myself so I know first hand. The team is putting a ton of effort to really reach new heights. It warms our hearts to hear that its recognized 🥲

I started a thread with the team to see if we can surface this information so it's easier for new contributors, the internals of c3i have this info so we'll see what they think :)

@conan-center-bot conan-center-bot merged commit a80eba1 into conan-io:master Aug 22, 2023
38 checks passed
@gegles gegles deleted the spdlog branch August 22, 2023 17:57
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 15, 2023
immortalsalomon pushed a commit to immortalsalomon/conan-center-index that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants