New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stella-cv-fbow: new recipe #23889

Draft

valgur wants to merge 6 commits into conan-io:master from valgur:new/stella-cv-fbow

+173 −0

Contributor

valgur commented May 6, 2024

Adds a stella-cv fork of FBoW: https://github.com/stella-cv/FBoW

FBoW (Fast Bag of Words) is an extremely optimized version of the DBoW2/DBoW3 libraries.
The library is highly optimized to speed up the Bag of Words creation using AVX,SSE and MMX instructions.

Required for packaging of https://github.com/stella-cv/stella_vslam


          stella-cv-fbow: new recipe

5da6ee3

prince-chrismc mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label

This comment has been minimized.

Sign in to view

valgur mentioned this pull request

stella_vslam: new recipe #23893

Open

This comment has been minimized.

Sign in to view


          stella-cv-fbow: more accurate handling of OpenCV deps

15f1e44

valgur force-pushed the new/stella-cv-fbow branch from 0987413 to 15f1e44 Compare

May 7, 2024 08:35

conan-center-bot removed the Failed label

This comment has been minimized.

Sign in to view

ericLemanissier mentioned this pull request

Pull Requests Ready to be Reviewed ericLemanissier/conan-center-index-pending-review#3

Open


          stella-cv-fbow: SIMD options are not available for MSVC

9f0fbf6

valgur force-pushed the new/stella-cv-fbow branch from 65d2b3f to 9f0fbf6 Compare

May 7, 2024 10:10

valgur mentioned this pull request

Avoid overlinking of OpenCV libs, clean up CMakeLists.txt a bit stella-cv/FBoW#14

Merged

This comment has been minimized.

Sign in to view


          stella-cv-fbow: update

76ad052

This comment has been minimized.

Sign in to view

RubenRBS self-assigned this

RubenRBS reviewed

View reviewed changes

Member

RubenRBS left a comment

Thanks! Minor comment about the cmake cxx standard variable, otherwise looks good :)

recipes/stella-cv-fbow/all/conanfile.py Show resolved Hide resolved

conan-center-bot requested a review from franramirez688

May 8, 2024 11:43


          stella-cv-fbow: let Conan set the C++ standard

273425e

Contributor Author

valgur commented May 8, 2024

Note: MSVC builds are currently skipped due to no llvm-openmp support for it. Requires #22353.

This comment has been minimized.

Sign in to view

RubenRBS previously approved these changes

View reviewed changes

toge reviewed

View reviewed changes

recipes/stella-cv-fbow/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved


          Fix error in test_package/CMakeLists.txt

f26c1a8

Co-authored-by: toge <toge.mail@gmail.com>

valgur dismissed RubenRBS’s stale review via

f26c1a8

May 12, 2024 08:36

valgur marked this pull request as draft

May 12, 2024 08:36

Collaborator

conan-center-bot commented May 12, 2024

Conan v1 pipeline ✔️

All green in build 8 (f26c1a88d4c3656076565268c19c047e2d049e6e):

stella-cv-fbow/cci.20240508:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (f26c1a88d4c3656076565268c19c047e2d049e6e):

stella-cv-fbow/cci.20240508:
All packages built successfully! (All logs)

jwillikers approved these changes

View reviewed changes

RubenRBS approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment