Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdf: refactor test package #23942

Merged
merged 8 commits into from May 24, 2024
Merged

sdf: refactor test package #23942

merged 8 commits into from May 24, 2024

Conversation

ErniGH
Copy link
Contributor

@ErniGH ErniGH commented May 9, 2024

Simplify the test_package in according to our policies:

  • Write the minimal test that tests the package (the compiler can find the correct includes, the static linker can resolve
    symbols, the runtime linker can resolve symbols).
  • Do not perform heavy logic in CI.
  • Remove binary blob - these have not been allowed anywhere in the repository for a while now, it's time to drop them where they exist

@conan-center-bot

This comment has been minimized.

Sign in to view
@ericLemanissier ericLemanissier mentioned this pull request May 9, 2024
Open
@RubenRBS RubenRBS self-assigned this May 10, 2024
@SpaceIm
Copy link
Contributor

SpaceIm commented May 10, 2024

It was already a minimal test package. Your proposed test package doesn't even call any function of sdf :/

@ErniGH
Copy link
Contributor Author

ErniGH commented May 10, 2024

@SpaceIm Oh well noted. The test was very good and was actually quite small. The change is actually to remove the binary files from our test packages. 😄

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries previously approved these changes May 14, 2024
View reviewed changes
@SpaceIm
Copy link
Contributor

SpaceIm commented May 14, 2024

stb should be removed from requirements in test package

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
RubenRBS
RubenRBS previously approved these changes May 16, 2024
View reviewed changes
@SpaceIm
Copy link
Contributor

SpaceIm commented May 16, 2024

There is still stb in conanfile of test_v1_package.

@RubenRBS RubenRBS self-requested a review May 16, 2024 19:27
@RubenRBS
Copy link
Member

Great catch @SpaceIm :)

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (af90e3a06370258427fdfd1a86c6ec7ebc83981f):

  • sdf/cci.20141013:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (af90e3a06370258427fdfd1a86c6ec7ebc83981f):

  • sdf/cci.20141013:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 25fa812 into conan-io:master May 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toge toge toge approved these changes

@RubenRBS RubenRBS RubenRBS approved these changes

@SpaceIm SpaceIm SpaceIm approved these changes

@uilianries uilianries uilianries left review comments

Assignees

@RubenRBS RubenRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ErniGH @conan-center-bot @SpaceIm @RubenRBS @toge @uilianries