qt: use upstream package folder architecture #23944
Open
+19
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille @paulharris you might be interested. 😉 |
|
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced May 10, 2024
|
I detected other pull requests that are modifying qt/5.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced May 10, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ericLemanissier
force-pushed
the
qt_folder
branch
from
eda9c5e
to
7ec37bb
Compare
This comment has been minimized.
This comment has been minimized.
jwillikers
approved these changes
May 10, 2024
ericLemanissier
force-pushed
the
qt_folder
branch
from
7ec37bb
to
941ff49
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 5526cb8qt/5.15.10@#ce23b7c5ed7a537d9e8e9082b15376e1 |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 3ecdb90qt/5.15.13@#ef4606a51f6eba0636beca056b50c04dqt/6.6.1@#6f1330e36e3a2e7455322956bad2b9feqt/6.6.3@#49ca2569fab72e107cb19f68d541f702qt/5.15.12@#f8f44d7bf79241afa050b4e94925ef14qt/6.6.0@#8310c6612c72c37239c4b3ad3b66aa53qt/5.15.10@#13da246ded307a5b2ed7dcf5a59ba6a0qt/5.15.11@#4688cdee15c40741cb25f9328d3b6cccqt/6.6.2@#85d59e524379169345c3c18905ee9b28qt/6.7.0@#ff7db6098aa777bf1a9b82ce7f8834ecqt/5.15.9@#07312ce1f2ae555243453553b42561bc |
|
@kambala-decapitator can you please try with this recipe and tell us if it solves your problem on android ? thanks ! |
|
@ericLemanissier will check tomorrow |
|
not sure what changed, but I can't build 5.15.13 for Android any more: the OpenGL ES test fails. Especially strange that it tries to use build profile environment to perform the test... I use v1.64.0. |
|
weird, removing And qtdeclarative build fails with an error that doesn't make much sense: https://bugreports.qt.io/browse/QTBUG-121530 although that's for Qt 6 |
|
passing |
|
Ok, so the main problem comes from the test_package, which requires qt in the build context : https://github.com/conan-io/conan-center-index/blob/master/recipes/qt/5.x.x/test_package/conanfile.py#L24. The markdown and ES2 problems are real, but are not related to android. |
|
thanks a lot, that worked perfectly! Used the following conanfile: all seems good: |
|
Thanks for the feedback. IIUC, the original problem is that |
|
yes, now androiddeployqt is able to copy plugins, thanks for the fix! |
jwillikers
approved these changes
May 14, 2024
This was referenced May 16, 2024
This comment has been minimized.
This comment has been minimized.
jwillikers
approved these changes
May 23, 2024
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ✔️
All green in build 8 (
|
Hooks produced the following warnings for commit b36f519qt/6.5.3@#73c8a8b509bbf19857c0adc653175e6eqt/6.3.2@#e2a1a85f1fbce074c5494f14e3a8d64eqt/6.7.0@#28622b3478abfef467a332b5c85ffa14qt/6.4.2@#5403500a758b29d0e8ef551bd7de8d0aqt/6.6.3@#4c527f49f491fd347264fdb3e18b6ce9qt/6.6.1@#ad3315386e942bde896b27068af1806cqt/6.6.0@#f7865fb7271f0600e3f934800efc3cdcqt/6.6.2@#ac8480d32d545728430eaaf04a7ca565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by conan-io/hooks#540
fixes #23660
Specify library name and version: qt/*