Add recipe for the bmx library provided by the BBC #23955

irieger · 2024-05-10T18:30:40Z

Specify library name and version: bmx/1.2 and bmx/cci.20240510

Currently I'm implementing something using the bmx library for handling video IO. Obviously, as I'm really settled on Conan now, I first created a package for the library which is so far missing.

As I'm looking into some options just recently added, besides the most recent 1.2 release I also added a snapshot in the usual form of cci.DATE for the current master branch.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

RubenRBS

Thanks! I'll have to check with the team about our handling of the -O2 directives present in the upstream cmakelist, but other than that and the few comments I've left, this looks great so far, thanks! :)

recipes/bmx/all/conanfile.py

…rsion

irieger · 2024-05-10T19:51:50Z

Any idea why uriparser isn't found in Conan 1?

ERROR: Missing prebuilt package for 'uriparser/0.9.8'

https://c3i.jfrog.io/c3i/misc/logs/pr/23955/3-linux-gcc-legacy/bmx/1.2//e2b8caa5d5af82d1dc00027a5bac8fb9e82e8e46-build.txt

RubenRBS · 2024-05-10T19:53:21Z

I'll regenerate the missing binaries now and restart the PR once they are ready

… of undefined references

irieger · 2024-05-11T08:57:09Z

@RubenRBS Again as in some other PRs, the result of the Conan 2 CI step doesn't get published here so I can't see the errors. At least locally I had working builds on Linux, Mac and Windows already so I'd like to see what fails.

RubenRBS · 2024-05-12T08:58:49Z

@irieger sorry about that. Sometimes the bot is a bit too eager to post th results and ends up not waiting for the v2 pipeline if it takes too long to finish - We're moving away from this solution in the new piepeline we're currently implementing, so that will be less of an issue soon-ish, thanks for your patience meanwhile!

The errors taht would have been posted are here: https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/pr/23955/5-windows-msvc/bmx/1.2//summary.json

Nevertheless I've now restarted the CI, the missing binaries were built a few days back but I haven't had a chance to trigger the CI again, let's see if that fixes the v1 piepeline completely :)

RubenRBS · 2024-05-12T09:52:49Z

The fact the uriparser is still missing tells us that there' something going on with some of the dependecies, will check on Monday, thanks for your patience :)

RubenRBS · 2024-05-12T14:13:02Z

Same v2 errors: https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/pr/23955/7-windows-msvc/bmx/1.2//summary.json

irieger · 2024-05-12T20:25:40Z

Somehow it tries to link to MXF.lib instead of MXF.dll when building shared. I'm trying to understand why that is but so far I haven't found any hint. The directory to the target is correct and the dll is there. Any idea where such a thing could come from?
I'm not really experienced with Windows development and its behaviour and on both macOS and Linux it also correctly solves to either the .a or .so/.dylib.

…es the patches to build with C++20 without non-cmake patches.

irieger · 2024-05-13T18:13:00Z

@RubenRBS Regarding your comment about -O2 in the first comment: Do you think it makes sense to get a patch upstream to remove a fixed -O2 in the CMake file? How is that normally done in Conan builds? Just checked my toolchain and found no hint where it might include any optimization options for the Release, unless they are hidden somewhere in one of the variables that are propagate, but search shows no "-O2". (Haven't anything manually in my profile.)

The BMX project seems very open to pull requests and was very helpful so far. So I assume if we suggest changes that don't affect the non-conan build cases, they are open to include stuff.

RubenRBS · 2024-05-13T19:42:14Z

@irieger I'll get back to you on that one tomorrow once I bounce the idea with @uilianries :)

RubenRBS · 2024-05-13T21:04:17Z

I'll investigate the uriparser missing binary tomorrow, this is not a case of it not being built :)

RubenRBS · 2024-05-16T14:20:11Z

@irieger check the linked PR for the C++ std issue - If you want to submit a report with the -O2 stuff too, that would be super appreciated too - else we can just patch it out locally here for now :)

irieger · 2024-05-16T20:04:27Z

@RubenRBS Raised a PR there: bbc/bmx#73

irieger · 2024-05-16T20:07:33Z

Also, any news on the missing Conan 1 dependency?

Also I think there has to be another issue leading to https://c3i.jfrog.io/c3i/misc-v2/logs/pr/23955/7-windows-msvc/bmx/1.2//83e068769ccbb48d8b698dfe31ce3ba8709e5cae-build.txt (It is a shared build and for some reason it tries to link MXF.lib, while correctly MXF.dll was built.)

…anges to the CMake not requiering most of the patches

irieger · 2024-05-17T15:35:24Z

Patched out the -O2 flag instances in the 1.2 release and bumped the CCI version to include the latest changes on master integrating all the fixes (fixed CXX version, -O2 flag and C++20 compatibility code fixes). That reduces the needed CMake patching to a minimal modification on how the dependencies are searched and linked.

conan-center-bot · 2024-05-23T08:04:45Z

Conan v1 pipeline ❌

Failure in build 14 (181a3d4a82d3dd46efb01a98174dbc47af0217be):

bmx/1.2:
CI failed to create some packages (All logs)

Logs for packageID fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d:

[settings]
arch=x86_64
build_type=Debug
compiler=Visual Studio
compiler.runtime=MDd
compiler.version=16
os=Windows
[options]
bmx:shared=True

[...]
LINK : fatal error LNK1104: cannot open file '..\mxf\Debug\MXF.lib' [C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build\_deps\libmxf-build\test\test_datamodel.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/src/deps/libMXF/test/CMakeLists.txt
  test_essencecontainer.c
LINK : fatal error LNK1104: cannot open file '..\mxf\Debug\MXF.lib' [C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build\_deps\libmxf-build\test\test_essencecontainer.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/src/deps/libMXF/test/CMakeLists.txt
  test_file.c
LINK : fatal error LNK1104: cannot open file '..\mxf\Debug\MXF.lib' [C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build\_deps\libmxf-build\test\test_file.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/src/deps/libMXF/test/CMakeLists.txt
  test_headermetadata.c
LINK : fatal error LNK1104: cannot open file '..\mxf\Debug\MXF.lib' [C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build\_deps\libmxf-build\test\test_headermetadata.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/src/deps/libMXF/test/CMakeLists.txt
  test_indextable.c
LINK : fatal error LNK1104: cannot open file '..\mxf\Debug\MXF.lib' [C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build\_deps\libmxf-build\test\test_indextable.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/src/deps/libMXF/test/CMakeLists.txt
  test_mxf_cache_file.c
LINK : fatal error LNK1104: cannot open file '..\mxf\Debug\MXF.lib' [C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build\_deps\libmxf-build\test\test_mxf_cache_file.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/src/deps/libMXF/test/CMakeLists.txt
  test_mxf_memory_file.c
LINK : fatal error LNK1104: cannot open file '..\mxf\Debug\MXF.lib' [C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build\_deps\libmxf-build\test\test_mxf_memory_file.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/src/deps/libMXF/test/CMakeLists.txt
  test_mxf_page_file.c
LINK : fatal error LNK1104: cannot open file '..\mxf\Debug\MXF.lib' [C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build\_deps\libmxf-build\test\test_mxf_page_file.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/src/deps/libMXF/test/CMakeLists.txt
  test_mxf_rw_intl_file.c
LINK : fatal error LNK1104: cannot open file '..\mxf\Debug\MXF.lib' [C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build\_deps\libmxf-build\test\test_mxf_rw_intl_file.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/src/deps/libMXF/test/CMakeLists.txt
  test_partition.c
LINK : fatal error LNK1104: cannot open file '..\mxf\Debug\MXF.lib' [C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build\_deps\libmxf-build\test\test_partition.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/src/deps/libMXF/test/CMakeLists.txt
  test_primer.c
LINK : fatal error LNK1104: cannot open file '..\mxf\Debug\MXF.lib' [C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build\_deps\libmxf-build\test\test_primer.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/src/tools/CMakeLists.txt
  vc2dump.c
  vc2dump.vcxproj -> C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build\tools\Debug\vc2dump.exe
  Building Custom Rule C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/src/deps/libMXF/test/CMakeLists.txt
  win32_cmd_test_file.c
  win32_cmd_test_file.vcxproj -> C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build\_deps\libmxf-build\test\Debug\win32_cmd_test_file.exe
bmx/1.2: 
-- Test samples output directory: C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/build/test_samples
-- Test samples output directory: C:/J/workspace/prod-v1/bsr/47597/dcefd/.conan/data/bmx/1.2/_/_/build/fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d/build/_deps/libmxf-build/test_samples
WARN: *** Conan 1 is legacy and on a deprecation path ***
WARN: *** Please upgrade to Conan 2 ***
WARN: openssl/3.2.1: requirement zlib/[>=1.2.11 <2] overridden by libcurl/8.6.0 to zlib/1.3.1 
bmx/1.2: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
bmx/1.2: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
bmx/1.2: ERROR: Package 'fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d' build failed
bmx/1.2: WARN: Build folder C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build
ERROR: bmx/1.2: Error in build() method, line 78
	cmake.build()
	ConanException: Error 1 while executing cmake --build "C:\J\workspace\prod-v1\bsr\47597\dcefd\.conan\data\bmx\1.2\_\_\build\fb7b0d1376e3633ae5a16fbaadbb948c0798ca8d\build" --config Debug

bmx/cci.20240517:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 14 (181a3d4a82d3dd46efb01a98174dbc47af0217be):

bmx/1.2:
Didn't run or was cancelled before finishing

bmx/cci.20240517:
CI failed to create some packages (All logs)

Logs for packageID 83e068769ccbb48d8b698dfe31ce3ba8709e5cae:

[settings]
arch=x86_64
build_type=Release
compiler=msvc
compiler.cppstd=14
compiler.runtime=dynamic
compiler.runtime_type=Release
compiler.version=192
os=Windows
[options]
*/*:shared=True

[...]
  movdump.vcxproj -> C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\tools\Release\movdump.exe
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/tools/CMakeLists.txt
  rdd36dump.c
  rdd36dump.vcxproj -> C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\tools\Release\rdd36dump.exe
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/deps/libMXF/test/CMakeLists.txt
  test_datamodel.c
LINK : fatal error LNK1181: cannot open input file '..\mxf\Release\MXF.lib' [C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\_deps\libmxf-build\test\test_datamodel.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/deps/libMXF/test/CMakeLists.txt
  test_essencecontainer.c
LINK : fatal error LNK1181: cannot open input file '..\mxf\Release\MXF.lib' [C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\_deps\libmxf-build\test\test_essencecontainer.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/deps/libMXF/test/CMakeLists.txt
  test_file.c
LINK : fatal error LNK1181: cannot open input file '..\mxf\Release\MXF.lib' [C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\_deps\libmxf-build\test\test_file.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/deps/libMXF/test/CMakeLists.txt
  test_headermetadata.c
LINK : fatal error LNK1181: cannot open input file '..\mxf\Release\MXF.lib' [C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\_deps\libmxf-build\test\test_headermetadata.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/deps/libMXF/test/CMakeLists.txt
  test_indextable.c
LINK : fatal error LNK1181: cannot open input file '..\mxf\Release\MXF.lib' [C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\_deps\libmxf-build\test\test_indextable.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/deps/libMXF/test/CMakeLists.txt
  test_mxf_cache_file.c
LINK : fatal error LNK1181: cannot open input file '..\mxf\Release\MXF.lib' [C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\_deps\libmxf-build\test\test_mxf_cache_file.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/deps/libMXF/test/CMakeLists.txt
  test_mxf_memory_file.c
LINK : fatal error LNK1181: cannot open input file '..\mxf\Release\MXF.lib' [C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\_deps\libmxf-build\test\test_mxf_memory_file.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/deps/libMXF/test/CMakeLists.txt
  test_mxf_page_file.c
LINK : fatal error LNK1181: cannot open input file '..\mxf\Release\MXF.lib' [C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\_deps\libmxf-build\test\test_mxf_page_file.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/deps/libMXF/test/CMakeLists.txt
  test_mxf_rw_intl_file.c
LINK : fatal error LNK1181: cannot open input file '..\mxf\Release\MXF.lib' [C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\_deps\libmxf-build\test\test_mxf_rw_intl_file.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/deps/libMXF/test/CMakeLists.txt
  test_partition.c
LINK : fatal error LNK1181: cannot open input file '..\mxf\Release\MXF.lib' [C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\_deps\libmxf-build\test\test_partition.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/deps/libMXF/test/CMakeLists.txt
  test_primer.c
LINK : fatal error LNK1181: cannot open input file '..\mxf\Release\MXF.lib' [C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\_deps\libmxf-build\test\test_primer.vcxproj]
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/tools/CMakeLists.txt
  vc2dump.c
  vc2dump.vcxproj -> C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\tools\Release\vc2dump.exe
  Building Custom Rule C:/J/workspace/prod-v2/bsr/42255/edeca/p/b/bmxd00a8769be3b0/b/src/deps/libMXF/test/CMakeLists.txt
  win32_cmd_test_file.c
  win32_cmd_test_file.vcxproj -> C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build\_deps\libmxf-build\test\Release\win32_cmd_test_file.exe

bmx/cci.20240517: ERROR: 
Package '83e068769ccbb48d8b698dfe31ce3ba8709e5cae' build failed
bmx/cci.20240517: WARN: Build folder C:\J\workspace\prod-v2\bsr\42255\edeca\p\b\bmxd00a8769be3b0\b\build
ERROR: bmx/cci.20240517: Error in build() method, line 78
	cmake.build()
	ConanException: Error 1 while executing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

irieger added 2 commits May 10, 2024 20:22

Add recipe for the bmx library provided by the BBC

20d814a

Add libcurl flag to conanfile

212bf98

RubenRBS self-assigned this May 10, 2024

RubenRBS reviewed May 10, 2024

View reviewed changes

recipes/bmx/all/conanfile.py Outdated Show resolved Hide resolved

recipes/bmx/all/conanfile.py Show resolved Hide resolved

Add version ranges for expat & libcurl and remove fixed target C++ ve…

2b286d3

…rsion

conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center labels May 10, 2024