Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7bitdi: add version 3.3.0 #23964

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

7bitdi: add version 3.3.0 #23964

wants to merge 2 commits into from
+14 −7

Conversation

toge
Copy link
Contributor

@toge toge commented May 12, 2024

Specify library name and version: 7bitdi/3.3.0

7bitcoder/7bitDI@v3.2.0...v3.3.0

@RubenRBS RubenRBS self-assigned this May 12, 2024
RubenRBS
RubenRBS reviewed May 12, 2024
View reviewed changes
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One minor comment about one of the changes, otherwise looks great as always :)

recipes/7bitdi/all/conanfile.py Outdated
@@ -48,6 +51,7 @@ def configure(self):
self.options.rm_safe("fPIC")
if self.options.header_only:
self.options.rm_safe("shared")
self.package_type = "header-library"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this is handled by conan automatically when the header_only option is set, but I can reference a test in the Conan main repo to make sure if you want! :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RubenRBS
Thank you for your review!
I removed this line.

@conan-center-bot

This comment has been minimized.

Sign in to view
@ericLemanissier ericLemanissier mentioned this pull request May 12, 2024
Closed
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (214f409726ae90ea6e49e4f7eafb467b8fa4a65e):

  • 7bitdi/3.3.0:
    All packages built successfully! (All logs)

  • 7bitdi/3.2.0:
    All packages built successfully! (All logs)

  • 7bitdi/1.0.0:
    All packages built successfully! (All logs)

  • 7bitdi/3.1.0:
    All packages built successfully! (All logs)

  • 7bitdi/3.0.0:
    All packages built successfully! (All logs)

  • 7bitdi/2.1.0:
    All packages built successfully! (All logs)

  • 7bitdi/2.0.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (214f409726ae90ea6e49e4f7eafb467b8fa4a65e):

  • 7bitdi/3.3.0:
    All packages built successfully! (All logs)

  • 7bitdi/3.2.0:
    All packages built successfully! (All logs)

  • 7bitdi/3.1.0:
    All packages built successfully! (All logs)

  • 7bitdi/3.0.0:
    All packages built successfully! (All logs)

  • 7bitdi/2.1.0:
    All packages built successfully! (All logs)

  • 7bitdi/2.0.0:
    All packages built successfully! (All logs)

  • 7bitdi/1.0.0:
    All packages built successfully! (All logs)

@ericLemanissier ericLemanissier mentioned this pull request May 12, 2024
Open
This was referenced May 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenRBS RubenRBS RubenRBS left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@RubenRBS RubenRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toge @conan-center-bot @RubenRBS