Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Boost build failure on Windows when not able to find MSVC toolset #5099

Merged

Conversation

ivabrajer
Copy link
Contributor

@ivabrajer ivabrajer commented Mar 31, 2021

Specify library name and version: boost/1.74.0

Closes #4338
Closes #4149


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2021

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@prince-chrismc
Copy link
Contributor

Looks like my suggestion from #4149 (comment)

Can you please add "closes #4149" in the opening comment 🙏 and please link the issue you already noted https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@ivabrajer
Copy link
Contributor Author

Looks like my suggestion from #4149 (comment)

Can you please add "closes #4149" in the opening comment 🙏 and please link the issue you already noted https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Will do, no problem. Thanks for approving!

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@conan-center-bot
Copy link
Collaborator

Failure in build 3 (b2254febbfee6c3fd662ca978b630a14253e60c7):

  • boost/1.69.0@:
    Didn't run or was cancelled before finishing

  • boost/1.70.0@:
    An unexpected error happened and has been reported

  • boost/1.71.0@:
    Didn't run or was cancelled before finishing

  • boost/1.72.0@:
    An unexpected error happened and has been reported

  • boost/1.75.0@:
    Didn't run or was cancelled before finishing

  • boost/1.73.0@:
    Didn't run or was cancelled before finishing

  • boost/1.74.0@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@prince-chrismc
Copy link
Contributor

You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁

Boost is very massive and some days it's harder to get a build to pass

@ivabrajer ivabrajer closed this Apr 6, 2021
@ivabrajer
Copy link
Contributor Author

Close/Re-open to trigger CI

@ivabrajer ivabrajer reopened this Apr 6, 2021
@conan-center-bot
Copy link
Collaborator

Failure in build 4 (b2254febbfee6c3fd662ca978b630a14253e60c7):

  • boost/1.69.0@:
    Didn't run or was cancelled before finishing

  • boost/1.70.0@:
    An unexpected error happened and has been reported

  • boost/1.72.0@:
    An unexpected error happened and has been reported

  • boost/1.71.0@:
    An unexpected error happened and has been reported

  • boost/1.73.0@:
    Didn't run or was cancelled before finishing

  • boost/1.74.0@:
    Didn't run or was cancelled before finishing

  • boost/1.75.0@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot
Copy link
Collaborator

Failure in build 5 (b2254febbfee6c3fd662ca978b630a14253e60c7):

  • boost/1.70.0@:
    An unexpected error happened and has been reported

  • boost/1.73.0@:
    An unexpected error happened and has been reported

  • boost/1.69.0@:
    All packages built successfully! (All logs)

  • boost/1.72.0@:
    An unexpected error happened and has been reported

  • boost/1.71.0@:
    Didn't run or was cancelled before finishing

  • boost/1.75.0@:
    Didn't run or was cancelled before finishing

  • boost/1.74.0@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot
Copy link
Collaborator

Failure in build 6 (b2254febbfee6c3fd662ca978b630a14253e60c7):

  • boost/1.71.0@:
    All packages built successfully! (All logs)

  • boost/1.69.0@:
    All packages built successfully! (All logs)

  • boost/1.70.0@:
    All packages built successfully! (All logs)

  • boost/1.75.0@:
    All packages built successfully! (All logs)

  • boost/1.72.0@:
    CI failed to create some packages (All logs)

    Logs for packageID 727d60343179b253bf28fa34a36c6113ac6a0a57:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Debug
    compiler=Visual Studio
    compiler.runtime=MDd
    compiler.version=16
    os=Windows
    os_build=Windows
    [options]
    boost:shared=False
    
      Building Custom Rule C:/J/w/BuildSingleReference@2/conan-center-index/recipes/boost/all/test_package/CMakeLists.txt
      Building Custom Rule C:/J/w/BuildSingleReference@2/conan-center-index/recipes/boost/all/test_package/CMakeLists.txt
      random.cpp
      fiber.cpp
      regex.cpp
      lambda.cpp
      locale.cpp
      test.cpp
    C:\J\w\BuildSingleReference@2\conan-center-index\recipes\boost\all\test_package\random.cpp(15,78): warning C4267: 'argument': conversion from 'size_t' to 'IntType', possible loss of data [C:\J\w\BuildSingleReference@2\conan-center-index\recipes\boost\all\test_package\build\1b8c8ab2ffb2312cd4c9d61e30db1d5c43f65eaf\random_exe.vcxproj]
              with
              [
                  IntType=int
              ]
    C:\J\w\BuildSingleReference@2\conan-center-index\recipes\boost\all\test_package\chrono.cpp(12,14): warning C4834: discarding return value of function with 'nodiscard' attribute [C:\J\w\BuildSingleReference@2\conan-center-index\recipes\boost\all\test_package\build\1b8c8ab2ffb2312cd4c9d61e30db1d5c43f65eaf\chrono_exe.vcxproj]
      random_exe.vcxproj -> C:\J\w\BuildSingleReference@2\conan-center-index\recipes\boost\all\test_package\build\1b8c8ab2ffb2312cd4c9d61e30db1d5c43f65eaf\bin\random_exe.exe
      chrono_exe.vcxproj -> C:\J\w\BuildSingleReference@2\conan-center-index\recipes\boost\all\test_package\build\1b8c8ab2ffb2312cd4c9d61e30db1d5c43f65eaf\bin\chrono_exe.exe
      lambda_exe.vcxproj -> C:\J\w\BuildSingleReference@2\conan-center-index\recipes\boost\all\test_package\build\1b8c8ab2ffb2312cd4c9d61e30db1d5c43f65eaf\bin\lambda_exe.exe
    MSBUILD : error MSB4166: Child node "2" exited prematurely. Shutting down. Diagnostic information may be found in files in "C:\J\w\BuildSingleReference@2\9080\87563438-b396-4979-b3e5-4b7ee5fcaa82\" and will be named MSBuild_*.failure.txt. This location can be changed by setting the MSBUILDDEBUGPATH environment variable to a different directory.
    C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1010,5): error MSB6006: "link.exe" exited with code -1073741502. [C:\J\w\BuildSingleReference@2\conan-center-index\recipes\boost\all\test_package\build\1b8c8ab2ffb2312cd4c9d61e30db1d5c43f65eaf\regex_exe.vcxproj]
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::boost libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::headers libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::_boost_cmake libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::_libboost libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::diagnostic_definitions libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::disable_autolinking libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::dynamic_linking libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::fiber_numa libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::math libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::stacktrace libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::stacktrace_addr2line libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::stacktrace_backtrace libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::stacktrace_basic libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::test libdir "lib" does not contain any declared library
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        Boost_USE_STATIC_LIBS
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    ERROR: boost/1.72.0 (test package): Error in build() method, line 38
    	cmake.build()
    	ConanException: Error 1 while executing cmake --build C:\J\w\BuildSingleReference@2\conan-center-index\recipes\boost\all\test_package\build\1b8c8ab2ffb2312cd4c9d61e30db1d5c43f65eaf --config Debug -- /m:16 /verbosity:minimal
    
  • boost/1.73.0@:
    All packages built successfully! (All logs)

  • boost/1.74.0@:
    CI failed to create some packages (All logs)

    Logs for packageID 8986a377a6792c67acd8cf052265d5edb8e72b55:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Debug
    compiler=Visual Studio
    compiler.runtime=MTd
    compiler.version=16
    os=Windows
    os_build=Windows
    [options]
    boost:shared=False
    
      regex.cpp
      nowide.cpp
      test.cpp
    C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\random.cpp(15,78): warning C4267: 'argument': conversion from 'size_t' to 'IntType', possible loss of data [C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7\random_exe.vcxproj]
              with
              [
                  IntType=int
              ]
    C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\chrono.cpp(12,14): warning C4834: discarding return value of function with 'nodiscard' attribute [C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7\chrono_exe.vcxproj]
      random_exe.vcxproj -> C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7\bin\random_exe.exe
      chrono_exe.vcxproj -> C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7\bin\chrono_exe.exe
      nowide_exe.vcxproj -> C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7\bin\nowide_exe.exe
      lambda_exe.vcxproj -> C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7\bin\lambda_exe.exe
    MSBUILD : error MSB4166: Child node "2" exited prematurely. Shutting down. Diagnostic information may be found in files in "C:\J\w\BuildSingleReference@12\9082\67f8f2a6-cee3-4a5b-af61-983924f899b1\" and will be named MSBuild_*.failure.txt. This location can be changed by setting the MSBUILDDEBUGPATH environment variable to a different directory.
    iconv.lib(iconv.obj) : warning LNK4099: PDB 'vc140.pdb' was not found with 'iconv.lib(iconv.obj)' or at 'C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7\bin\vc140.pdb'; linking object as if no debug info [C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7\locale_exe.vcxproj]
    iconv.lib(localcharset.obj) : warning LNK4099: PDB 'vc140.pdb' was not found with 'iconv.lib(localcharset.obj)' or at 'C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7\bin\vc140.pdb'; linking object as if no debug info [C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7\locale_exe.vcxproj]
    C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1010,5): error MSB6006: "link.exe" exited with code 1. [C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7\locale_exe.vcxproj]
    C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1010,5): error MSB6006: "link.exe" exited with code -1073741502. [C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7\test_exe.vcxproj]
    C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1010,5): error MSB6006: "link.exe" exited with code 1. [C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7\regex_exe.vcxproj]
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::boost libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::headers libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::_boost_cmake libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::_libboost libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::diagnostic_definitions libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::disable_autolinking libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::dynamic_linking libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::fiber_numa libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::math libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::stacktrace libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::stacktrace_addr2line libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::stacktrace_backtrace libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::stacktrace_basic libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component boost::test libdir "lib" does not contain any declared library
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        Boost_USE_STATIC_LIBS
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    ERROR: boost/1.74.0 (test package): Error in build() method, line 38
    	cmake.build()
    	ConanException: Error 1 while executing cmake --build C:\J\w\BuildSingleReference@12\conan-center-index\recipes\boost\all\test_package\build\6454774a9b2ac8ae7f3372322d83ddcaddd916e7 --config Debug -- /m:16 /verbosity:minimal
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@prince-chrismc
Copy link
Contributor

MSBUILD : error MSB4166: Child node "2" exited prematurely

Again...

One more restart is needed 🤞

@ivabrajer
Copy link
Contributor Author

Again...

One more restart is needed 🤞

Oh man, at least it's morning here so I can restart this thing the whole day.

@conan-center-bot
Copy link
Collaborator

All green in build 7 (b2254febbfee6c3fd662ca978b630a14253e60c7):

  • boost/1.69.0@:
    All packages built successfully! (All logs)

  • boost/1.71.0@:
    All packages built successfully! (All logs)

  • boost/1.70.0@:
    All packages built successfully! (All logs)

  • boost/1.75.0@:
    All packages built successfully! (All logs)

  • boost/1.72.0@:
    All packages built successfully! (All logs)

  • boost/1.73.0@:
    All packages built successfully! (All logs)

  • boost/1.74.0@:
    All packages built successfully! (All logs)

@ivabrajer
Copy link
Contributor Author

@prince-chrismc All passed, but since I'm not authorized to merge I have to wait for more reviewers or you can merge if you have permissions to do it.

@prince-chrismc
Copy link
Contributor

prince-chrismc commented Apr 7, 2021

Sadly no one has permission =) https://github.com/conan-io/conan-center-index/blob/master/docs/review_process.md#getting-your-pull-request-reviewed ... The the evil bots taking over the world 🤖

My bot picked it up and ur PR is "ready for review" prince-chrismc/conan-center-index-pending-review#1

@SSE4 SSE4 requested a review from uilianries April 7, 2021 13:13
@ericLemanissierBot ericLemanissierBot mentioned this pull request Apr 13, 2021
4 tasks
prince-chrismc referenced this pull request in prince-chrismc/conan-center-index-pending-review Apr 14, 2021
prince-chrismc referenced this pull request in prince-chrismc/conan-center-index-pending-review Apr 15, 2021
@prince-chrismc
Copy link
Contributor

prince-chrismc commented Apr 23, 2021

👋 This is a 4 line diff... please take a look 🙏

@SSE4
@uilianries
@madebr
@SpaceIm
@ericLemanissier
@Croydon
@intelligide
@theirix
@gocarlos
@mathbunnyru

If you see this, prince-chrismc/conan-center-index-pending-review#1 has more "going stale" but good PRs

Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I am really really tentative to approve that... it's just 4 lines diff, but situation isn't trivial, as I've said already, it might be fixing one thing, but breaking another thing (see #3362 (comment)). it might be possible there is no way to make it working correctly for everyone, in the end. but as several people reported it improves workflows for them, let's merge it.

@prince-chrismc
Copy link
Contributor

but situation isn't trivial

💯 agreed

In your comment #3362 (comment), most people expecting it be multiple arguments are UNIX consumers... When using MSVC you typically expect it to be quoted (since it's picked up by default with spaces)

I hope this will keep both user bases happy 🤞

@conan-center-bot conan-center-bot merged commit 301f6ef into conan-io:master Apr 24, 2021
@ivabrajer ivabrajer deleted the ibrajer-boost-msvc-fix branch April 26, 2021 06:52
AndreyMlashkin pushed a commit to AndreyMlashkin/conan-center-index that referenced this pull request Apr 26, 2021
AlvaroFS pushed a commit to AlvaroFS/conan-center-index that referenced this pull request May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] boost/1.75.0: Build fails on windows
8 participants