[protobuf] Only find protoc when cross compiling #5258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use find_program to search for protoc if cross compiling.
This is to make sure a system installed protoc is never used in
a normal situation while still allowing a build profile (or system)
protoc to be used when cross compiling.
This fixes an issue introduced in #4556 that would cause a system installed protoc to have a higher priority when a project is built using cmake-conan (https://github.com/conan-io/cmake-conan).
I created a minimal project and a few scripts to try to make sure it works in the situation I could imagine, see:
https://github.com/anton-danielsson/test-conan-protobuf
Specify library name and version: protobuf
conan-center hook activated.