conanized zlib-ng 2.0.0 #5264
Merged
conanized zlib-ng 2.0.0 #5264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tkrupa <tomas@krupa.hu>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: tkrupa <tomas@krupa.hu>
This comment has been minimized.
This comment has been minimized.
prince-chrismc
suggested changes
Apr 23, 2021
Signed-off-by: tkrupa <tomas@krupa.hu>
Test package following common template Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Signed-off-by: tkrupa <tomas@krupa.hu>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: tkrupa <tomas@krupa.hu>
This comment has been minimized.
This comment has been minimized.
uilianries
reviewed
Apr 23, 2021
Signed-off-by: tkrupa <tomas@krupa.hu>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: tkrupa <tomas@krupa.hu>
This comment has been minimized.
This comment has been minimized.
prince-chrismc
previously approved these changes
Apr 24, 2021
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
@tomas-krupa Consider tomas-krupa#1 I see many points to be improved, also your recipe is not complete yet, defines are missing. |
Improve zlib-ng by uilian
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
prince-chrismc
suggested changes
Apr 27, 2021
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
|
All green in build 14 (
|
prince-chrismc
approved these changes
Apr 29, 2021
SSE4
approved these changes
May 3, 2021
danimtb
approved these changes
May 4, 2021
|
ping @uilianries, I think you need to approve to update previous review |
|
It should be good to go 🤞 prince-chrismc/conan-center-index-pending-review#1 Has this in ready to merge 🎉 |
AlvaroFS
pushed a commit
to AlvaroFS/conan-center-index
that referenced
this pull request
May 7, 2021
* conanized zlib-ng 2.0.0 Signed-off-by: tkrupa <tomas@krupa.hu> * removed win static lib suffix Signed-off-by: tkrupa <tomas@krupa.hu> * conanized useful cmake options Signed-off-by: tkrupa <tomas@krupa.hu> * Update recipes/zlib-ng/all/test_package/conanfile.py Test package following common template Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * reduced test package Signed-off-by: tkrupa <tomas@krupa.hu> * test_package depending on zlib.ng explicitely Signed-off-by: tkrupa <tomas@krupa.hu> * using upstream cmake install Signed-off-by: tkrupa <tomas@krupa.hu> * Update recipes/zlib-ng/all/test_package/test_package.c Co-authored-by: Uilian Ries <uilianries@gmail.com> * using cmake wrapper Signed-off-by: tkrupa <tomas@krupa.hu> * Improve zlib-ng Signed-off-by: Uilian Ries <uilianries@gmail.com> * Update recipes/zlib-ng/all/conandata.yml Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/zlib-ng/config.yml Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/zlib-ng/all/test_package/test_package.c Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/zlib-ng/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update recipes/zlib-ng/all/test_package/CMakeLists.txt Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update recipes/zlib-ng/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: zlib-ng/2.0.0
zlib data compression library for the next generation systems
Author: Hans Kristian Rosbach aka Dead2
Homepage: https://github.com/zlib-ng/zlib-ng
conan-center hook activated.