Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt: raise conan libs priority vs system libs #6019

Merged
merged 3 commits into from Jun 26, 2021
Merged

qt: raise conan libs priority vs system libs #6019

merged 3 commits into from Jun 26, 2021

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Jun 22, 2021 •
edited

Specify library name and version: qt/5.15.2

fixes #5824
fixes #5931

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ericLemanissierBot ericLemanissierBot mentioned this pull request Jun 22, 2021
Open
@ericLemanissierBot
Copy link

ericLemanissierBot commented Jun 22, 2021 •
edited

I detected other pull requests that are modifying qt/5.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

This was referenced Jun 22, 2021
Merged
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@AndreyMlashkin
Copy link
Contributor

worked for me locally

AndreyMlashkin
AndreyMlashkin previously approved these changes Jun 22, 2021
View reviewed changes
@conan-center-bot

This comment has been minimized.

Sign in to view
AndreyMlashkin
AndreyMlashkin previously approved these changes Jun 22, 2021
View reviewed changes
@github-actions github-actions bot mentioned this pull request Jun 22, 2021
Open
@ericLemanissierBot ericLemanissierBot mentioned this pull request Jun 22, 2021
Merged
4 tasks
uilianries
uilianries previously approved these changes Jun 23, 2021
View reviewed changes
@AndreyMlashkin
Copy link
Contributor

@SpaceIm @CAMOBAP @ruilvo @Renari
Please approve somebody

SpaceIm
SpaceIm previously approved these changes Jun 24, 2021
View reviewed changes
@ruilvo
Copy link
Contributor

ruilvo commented Jun 24, 2021 •
edited

@AndreyMlashkin I'm not a conan dev hahaha My approvals do nothing. Also, there's a feature on the right sidebar to ask for reviews :)

edit: and also, notice the bot writes things pending review here, so the devs will notice them :)

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Jun 24, 2021

@AndreyMlashkin the same to me, I haven't permissions to approve

@ericLemanissier
fix test recipe
a0c3c3f 
qmake already links to qt libraries
@conan-center-bot

This comment has been minimized.

Sign in to view
@ericLemanissier
Copy link
Contributor Author

trigger CI

@conan-center-bot
Copy link
Collaborator

All green in build 4 (a0c3c3fb3e628d4a925f127dce83749557dc633f):

  • qt/5.15.2@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 39a9ad7 into conan-io:master Jun 26, 2021
@CroydonBot CroydonBot deleted the qt branch June 26, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@AndreyMlashkin AndreyMlashkin AndreyMlashkin approved these changes

@uilianries uilianries uilianries approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@SpaceIm SpaceIm SpaceIm left review comments

@danimtb danimtb Awaiting requested review from danimtb

@jgsogo jgsogo Awaiting requested review from jgsogo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
10 participants
@ericLemanissier @ericLemanissierBot @conan-center-bot @AndreyMlashkin @ruilvo @CAMOBAP @SSE4 @uilianries @prince-chrismc @SpaceIm