Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render diffs with unlimited depth #61

Closed
wants to merge 14 commits into from
Closed

Render diffs with unlimited depth #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9f6475e
Added test for plugins
bunysae Mar 10, 2020
b556bbc
Added tests for plugin registry
bunysae Mar 12, 2020
e3297b7
Added test for serialization with plugins
bunysae Mar 14, 2020
90173d9
Updated snapshots
bunysae Mar 24, 2020
08efb99
fixed linter issues
bunysae Mar 26, 2020
d828fad
Refactoring: use snapshot for and register pattern
bunysae Apr 4, 2020
f579349
Use plugin factory pattern
novemberborn Apr 4, 2020
3b36f63
Add test for diff-function
bunysae Apr 22, 2020
64329a0
Improve code-coverage for function descriptor
bunysae Apr 22, 2020
841abfe
Merge branch 'master' of https://github.com/bunysae/concordance
bunysae Apr 22, 2020
2a89f94
Merge https://github.com/concordancejs/concordance
bunysae Apr 22, 2020
2ddba8f
Restore function.js
bunysae Apr 28, 2020
cd54c11
render diff with unlimited depth
bunysae May 8, 2020
67cb3da
Merge https://github.com/concordancejs/concordance
bunysae May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/diff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ function diffDescriptors (lhs, rhs, options) {
const lhsCircular = new Circular()
const rhsCircular = new Circular()
const maxDepth = (options && options.maxDepth) || 0
const renderDiffWithUnlimitedDepth = (options && options.renderDiffWithUnlimitedDepth)

let indent = new Indenter(0, ' ')

Expand Down Expand Up @@ -113,7 +114,7 @@ function diffDescriptors (lhs, rhs, options) {
const formatter = subject.formatShallow(themeUtils.applyModifiers(subject, theme), indent)
const recursor = subject.createRecursor()

if (formatter.increaseIndent && maxDepth > 0 && indent.level === maxDepth) {
if (formatter.increaseIndent && maxDepth > 0 && indent.level === maxDepth && !renderDiffWithUnlimitedDepth) {
const isEmpty = recursor() === null
let formatted = !isEmpty && typeof formatter.maxDepth === 'function'
? formatter.maxDepth()
Expand Down