Fix: enable closing the data picker by clicking on ClosedPanels
#4952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #10597: Bundle Size — 62.24MiB (~-0.01%).
Warning Bundle contains 58 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #10597 report View fix/data-picker-click-out branch activity View project dashboard |
bkrmendy
changed the title
ClosedPanels
|
Performance test results: |
bkrmendy
changed the title
ClosedPanelsClosedPanels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The data picker cannot be closed when the area highlighted in blue is clicked.
Actually, none of the modal or context menus can be closed when that area is clicked.
Fix
The area highlighted in blue is the
ClosedPanelscomponent, which intercepts the mouse click. This PR fixes up the CSS + click handlers inClosedPanels, and refactors the data picker to useInspectorModal, so that its modal behaviour is in line with the rest of the modals in the editor.