Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click to insert on empty render prop #4972

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Click to insert on empty render prop #4972

wants to merge 1 commit into from

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Feb 28, 2024

Problem:
Describe the problem being addressed as succinctly as possible.

Fix:
Describe the fix you have made as succinctly as possible.

Commit Details: (< vv pls delete this section if's not relevant)

  • Renamed thing to otherThing
  • Removed cake from fridge-contents.ts
  • Did [other things]

Fixes #[ticket_number] (<< pls delete this line if it's not relevant)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Feb 28, 2024

Job #10660: Bundle Size — 62.5MiB (~+0.01%).

7ed760f(current) vs f583697 master#10658(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10660		      Baseline
Job #10658
Regression  Initial JS 45.72MiB(~+0.01%) 45.71MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.27% 20.25%
No change  Chunks 34 34
No change  Assets 38 38
No change  Modules 4392 4392
No change  Duplicate Modules 523 523
No change  Duplicate Code 30.96% 30.96%
No change  Packages 467 467
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10660		      Baseline
Job #10658
Regression  JS 62.48MiB (~+0.01%) 62.48MiB
Improvement  HTML 12.61KiB (-0.39%) 12.66KiB

View job #10660 report View feature/click-to-insert-on-empty... branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gbalint