Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix data picker tests #5399

Closed
wants to merge 2 commits into from
Closed

fix data picker tests #5399

wants to merge 2 commits into from

Conversation

bkrmendy
Copy link
Contributor

Problem:
Describe the problem being addressed as succinctly as possible.

Fix:
Describe the fix you have made as succinctly as possible.

Commit Details: (< vv pls delete this section if's not relevant)

  • Renamed thing to otherThing
  • Removed cake from fridge-contents.ts
  • Did [other things]

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Fixes #[ticket_number] (<< pls delete this line if it's not relevant)

@bkrmendy bkrmendy linked an issue Apr 25, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Apr 25, 2024

Try me

Copy link

relativeci bot commented Apr 25, 2024

#11915 Bundle Size — 62.32MiB (~+0.01%).

0f5e40b(current) vs 6339ece master#11908(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#11915
     Baseline
#11908
Regression  Initial JS 45.41MiB(~+0.01%) 45.41MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 20.91% 20.91%
No change  Chunks 31 31
No change  Assets 34 34
No change  Modules 4368 4368
No change  Duplicate Modules 503 503
No change  Duplicate Code 30.82% 30.82%
No change  Packages 467 467
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#11915
     Baseline
#11908
Regression  JS 62.31MiB (~+0.01%) 62.31MiB
Improvement  HTML 10.94KiB (-0.34%) 10.98KiB

Bundle analysis reportBranch tests/fix-data-picker-testsProject dashboard

Copy link
Contributor

github-actions bot commented Apr 25, 2024

Performance test results:
Highlight Regular (1%)

Highlight All Elements (2%)

Selection (2%)

De-Selection (33%)
Before: 10.5ms (9.2-14.8ms)
After: 14ms (9-20.7ms)

Selection Change (-1%)

Scroll Canvas (0%)

(Chart1)
(Chart2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant