Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/use-map-expression-preferred-contents #5641

Closed
wants to merge 2 commits into from

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented May 8, 2024

Problem:
Describe the problem being addressed as succinctly as possible.

Fix:
Describe the fix you have made as succinctly as possible.

Commit Details: (< vv pls delete this section if's not relevant)

  • Renamed thing to otherThing
  • Removed cake from fridge-contents.ts
  • Did [other things]

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Fixes #[ticket_number] (<< pls delete this line if it's not relevant)

Copy link
Contributor

github-actions bot commented May 8, 2024

Try me

Copy link

relativeci bot commented May 8, 2024

#12339 Bundle Size — 62.5MiB (~+0.01%).

431b42d(current) vs 6339ece master#12336(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#12339
     Baseline
#12336
Regression  Initial JS 45.58MiB(~+0.01%) 45.57MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.53% 23.39%
No change  Chunks 31 31
No change  Assets 34 34
No change  Modules 4378 4378
No change  Duplicate Modules 504 504
No change  Duplicate Code 30.8% 30.8%
No change  Packages 468 468
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#12339
     Baseline
#12336
Regression  JS 62.49MiB (~+0.01%) 62.49MiB
Improvement  HTML 10.94KiB (-0.34%) 10.98KiB

Bundle analysis reportBranch fix/use-map-expression-preferred...Project dashboard

Copy link
Contributor

github-actions bot commented May 8, 2024

Performance test results:
(Chart1)
(Chart2)

@bkrmendy bkrmendy closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant