-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap an element using the new component picker #5691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#12533 Bundle Size — 62.14MiB (~+0.01%).
Warning Bundle contains 52 duplicate packages – View duplicate packages Bundle metrics
|
Current #12533 |
Baseline #12522 |
|
---|---|---|
Initial JS | 45.21MiB (~+0.01% ) |
45.21MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 21.46% |
21.38% |
Chunks | 30 |
30 |
Assets | 33 |
33 |
Modules | 4288 (+0.05% ) |
4286 |
Duplicate Modules | 519 (+0.39% ) |
517 |
Duplicate Code | 31.01% |
31.01% |
Packages | 449 |
449 |
Duplicate Packages | 52 |
52 |
Bundle size by type 2 changes
1 regression
1 improvement
Current #12533 |
Baseline #12522 |
|
---|---|---|
JS | 62.13MiB (~+0.01% ) |
62.12MiB |
HTML | 10.94KiB (-0.34% ) |
10.97KiB |
Bundle analysis report Branch feat/wrap-with-context Project dashboard
liady
changed the title
Feat/wrap with context
Prep PR - Wrap a single element using the component picker
May 16, 2024
liady
changed the title
Prep PR - Wrap a single element using the component picker
Wrap an element using the new component picker
May 16, 2024
bkrmendy
approved these changes
May 16, 2024
seanparsons
approved these changes
May 16, 2024
Rheeseyb
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The "Wrap" feature currently doesn't use the new component picker
Fix:
This PR makes the "Wrap..." option use the new component picker - currently only for a single element. (subsequent PR for supporting multiple selection).
This PR includes:
This PR doesn't include:
Monosnap.screencast.2024-05-16.12-50-11.mp4
This PR also skips the element tests (5ac6d25) that will be re-enabled in the subsequent PR
Related to #5442