Data picker - code cleanup #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fix/data-picker-cleanup
#12538 Bundle Size — 62.13MiB (~-0.01%).
Warning Bundle contains 52 duplicate packages – View duplicate packages Bundle metrics
|
| Current #12538 |
Baseline #12534 |
|
|---|---|---|
 Initial JS |
45.21MiB(~-0.01%) |
45.21MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
22.71% |
21.44% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4288 |
4288 |
| Duplicate Modules |
519 |
519 |
| Duplicate Code |
31.01% |
31.01% |
| Packages |
449 |
449 |
| Duplicate Packages |
52 |
52 |
Bundle size by type 2 changes 2 improvements
| Current #12538 |
Baseline #12534 |
|
|---|---|---|
| JS |
62.12MiB (~-0.01%) |
62.13MiB |
| HTML |
10.94KiB (-0.34%) |
10.97KiB |
Bundle analysis report Branch fix/data-picker-cleanup Project dashboard
|
Performance test results: |
bkrmendy
commented
May 21, 2024
Comment on lines
-484
to
-485
| background: currentExpressionExactMatch ? colorTheme.primary.value : undefined, | ||
| color: currentExpressionExactMatch ? colorTheme.white.value : undefined, |
There was a problem hiding this comment.
Since the data picker UX isn't final yet, I didn't fix this up
…to fix/data-picker-cleanup
balazsbajorics
approved these changes
May 21, 2024
seanparsons
reviewed
May 21, 2024
| return element | ||
| } | ||
| const replacementPath = action.replacementPath | ||
| if (replacementPath.type === 'replace-child-with-uid') { |
There was a problem hiding this comment.
Why not use a switch statement here?
There was a problem hiding this comment.
Thanks for calling it out, neither is ideal so I refactored it to a switch + helper functions in 0b1d170
seanparsons
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The data picker control is structured in a way that makes it hard to use for use cases other than picking data for properties
Fix
This PR refactors the data picker so that both the variables it displays and the callback that's called when a variable is clicked are passed in from the call site. This way, we can provide the variables that make sense for properties, map expression values or child nodes.
Commit Details
UpdateMapExpressionaction is removed and its functionality is rolled intoReplaceElementInScopeElementReplacementPathto cater to properties and mapped expression, and theReplaceElementInScopeaction is updated to interpret these modesuseDataPickerButtonandDataPickerComponentare refactored so that the variable options to display and the callback that's called when an option is picked are passed in from the outsideDataPickerTypeanduseDataPickerButtonListSourceare removed, because the functionality they implemented is superseded by passing in the variables and the callbackOut of scope
#5684 mentions updating the logic that gets the runtime value of variables. This PR doesn't directly fix that, but since the logic related to variables is contained in
useVariablesInScopeForSelectedElement, this PR unblocks making this change (because with this, the various call sites in different contexts can pass in whatever variables they deem fit).Manual Tests
I hereby swear that:
Related to #5684