Scope editor css to only affect the editor #5708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#12521 Bundle Size — 62.13MiB (~+0.01%).
Warning Bundle contains 52 duplicate packages – View duplicate packages Bundle metrics
|
| Current #12521 |
Baseline #12519 |
|
|---|---|---|
 Initial JS |
45.21MiB(~+0.01%) |
45.21MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.39% |
21.37% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4286 |
4286 |
| Duplicate Modules |
517 |
517 |
| Duplicate Code |
31.01% |
31.01% |
| Packages |
449 |
449 |
| Duplicate Packages |
52 |
52 |
Bundle size by type 2 changes 2 regressions
| Current #12521 |
Baseline #12519 |
|
|---|---|---|
| JS |
62.12MiB (~+0.01%) |
62.12MiB |
| HTML |
11.16KiB (+1.7%) |
10.97KiB |
Bundle analysis report Branch fix/scope-editor-css Project dashboard
|
Performance test results: |
Rheeseyb
changed the title
Rheeseyb
requested review from
gbalint,
seanparsons,
ruggi,
balazsbajorics,
liady and
bkrmendy
Rheeseyb
commented
May 21, 2024
Comment on lines
1
to
3
| body { | ||
| margin: 0; | ||
| background-color: transparent; | ||
| font-family: 'utopian-inter', 'sans-serif'; | ||
| font-size: 11px !important; | ||
| font-feature-settings: 'cv01', 'tnum', 'zero'; | ||
| letter-spacing: 0.2px; | ||
| line-height: 17px; | ||
| overflow: hidden; | ||
| outline: none; | ||
| overscroll-behavior-x: contain; | ||
| } | ||
|
|
||
| a { | ||
| text-decoration: none; | ||
| color: #007aff; | ||
| } |
There was a problem hiding this comment.
This was required as the Hydrogen project includes the body tag, which by default has a margin. We've always been setting the margin to zero and accidentally relying on the editor CSS bleeding
gbalint
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Editor CSS is leaking into the user projects.
Fix:
By wrapping all editor CSS in
@scoperules that define upper and lower bounds, we can create what's referred to as a "donut scope" which can be applied to everything but the Canvas Container (https://developer.mozilla.org/en-US/docs/Web/CSS/@scope#scope_roots_and_scope_limits).It's best to view this diff with whitespace hidden.
Part of #5697