Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pti-gpu-unitrace #26302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZzEeKkAa
Copy link

@ZzEeKkAa ZzEeKkAa commented May 9, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
    !There is no tarball release!
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pti-gpu-unitrace) and found some lint.

Here's what I've got...

For recipes/pti-gpu-unitrace:

  • The following maintainers have not yet confirmed that they are willing to be listed here: oleksandr-pavlyk. Please ask them to comment on this PR if they are.

For recipes/pti-gpu-unitrace:

@oleksandr-pavlyk
Copy link
Contributor

I do not object to being a maintainer of this package. unitrace is a useful utility for triaging offload activity of SYCL applications.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pti-gpu-unitrace) and found it was in an excellent condition.

@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review May 9, 2024 17:30
@ZzEeKkAa
Copy link
Author

ZzEeKkAa commented May 9, 2024

@conda-forge/help-c-cpp, ready for review!

@ZzEeKkAa
Copy link
Author

@xhochy sorry to ping you directly, but I've seen that you are reviewing c-cpp recipes. Does anything needed to add to this repo and what the following steps to get it merged?

recipes/pti-gpu-unitrace/meta.yaml Outdated Show resolved Hide resolved
recipes/pti-gpu-unitrace/meta.yaml Outdated Show resolved Hide resolved
Comment on lines 31 to 33
- {{ pin_compatible('intel-cmplr-lib-rt', min_pin='x.x', max_pin='x') }}
- {{ pin_compatible('ocl-icd', min_pin='x.x', max_pin='x') }}
- {{ pin_compatible('level-zero', min_pin='x.x', max_pin='x') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these probably should have a run_exports and thus should not be listed explicitly here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunetely no.

Without those pins I have warnings during the build time:

Packaging pti-gpu-unitrace
Packaging pti-gpu-unitrace-0.0.1-h07fc403_0
number of files: 13
   INFO: sysroot: '/home/yevhenii/.miniforge3/conda-bld/pti-gpu-unitrace_1716226117221/_build_env/x86_64-conda-linux-gnu/sysroot/' files: '['/home/yevhenii/.miniforge3/conda-bld/pti-gpu-unitrace_1716226117221/_build_env/x86_64-conda-linux-gnu/sysroot/usr/share/zoneinfo/zone1970.tab', '/home/yevhenii/.miniforge3/conda-bld/pti-gpu-unitrace_1716226117221/_build_env/x86_64-conda-linux-gnu/sysroot/usr/share/zoneinfo/zone.tab', '/home/yevhenii/.miniforge3/conda-bld/pti-gpu-unitrace_1716226117221/_build_env/x86_64-conda-linux-gnu/sysroot/usr/share/zoneinfo/tzdata.zi', '/home/yevhenii/.miniforge3/conda-bld/pti-gpu-unitrace_1716226117221/_build_env/x86_64-conda-linux-gnu/sysroot/usr/share/zoneinfo/right/Zulu']'
   INFO (pti-gpu-unitrace,bin/unitrace): Needed DSO x86_64-conda-linux-gnu/sysroot/lib64/libpthread.so.0 found in CDT/compiler package conda-forge/noarch::sysroot_linux-64==2.17=h4a8ded7_14
WARNING (pti-gpu-unitrace,bin/unitrace): Needed DSO lib/libze_loader.so.1 found in ['conda-forge/linux-64::level-zero==1.17.0=h297d8ca_0']
WARNING (pti-gpu-unitrace,bin/unitrace): .. but ['conda-forge/linux-64::level-zero==1.17.0=h297d8ca_0'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
   INFO (pti-gpu-unitrace,bin/unitrace): Needed DSO lib/libstdc++.so.6 found in conda-forge/linux-64::libstdcxx-ng==13.2.0=hc0a3c3a_7
   INFO (pti-gpu-unitrace,bin/unitrace): Needed DSO lib/libgcc_s.so.1 found in conda-forge/linux-64::libgcc-ng==13.2.0=h77fa898_7
   INFO (pti-gpu-unitrace,bin/unitrace): Needed DSO x86_64-conda-linux-gnu/sysroot/lib64/libc.so.6 found in CDT/compiler package conda-forge/noarch::sysroot_linux-64==2.17=h4a8ded7_14
WARNING (pti-gpu-unitrace,bin/libunitrace_tool.so): $RPATH/libxptifw.so not found in packages, sysroot(s) nor the missing_dso_whitelist.
.. is this binary repackaging?
WARNING (pti-gpu-unitrace,bin/libunitrace_tool.so): $RPATH/libOpenCL.so.1 not found in packages, sysroot(s) nor the missing_dso_whitelist.
.. is this binary repackaging?
WARNING (pti-gpu-unitrace,bin/libunitrace_tool.so): Needed DSO lib/libze_loader.so.1 found in ['conda-forge/linux-64::level-zero==1.17.0=h297d8ca_0']
WARNING (pti-gpu-unitrace,bin/libunitrace_tool.so): .. but ['conda-forge/linux-64::level-zero==1.17.0=h297d8ca_0'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
   INFO (pti-gpu-unitrace,bin/libunitrace_tool.so): Needed DSO lib/libstdc++.so.6 found in conda-forge/linux-64::libstdcxx-ng==13.2.0=hc0a3c3a_7
   INFO (pti-gpu-unitrace,bin/libunitrace_tool.so): Needed DSO lib/libgcc_s.so.1 found in conda-forge/linux-64::libgcc-ng==13.2.0=h77fa898_7
WARNING (pti-gpu-unitrace,bin/libunitrace_tool.so): $RPATH/libintlc.so.5 not found in packages, sysroot(s) nor the missing_dso_whitelist.
.. is this binary repackaging?
   INFO (pti-gpu-unitrace,bin/libunitrace_tool.so): Needed DSO x86_64-conda-linux-gnu/sysroot/lib64/libc.so.6 found in CDT/compiler package conda-forge/noarch::sysroot_linux-64==2.17=h4a8ded7_14
   INFO (pti-gpu-unitrace,bin/libunitrace_tool.so): Needed DSO x86_64-conda-linux-gnu/sysroot/lib64/ld-linux-x86-64.so.2 found in CDT/compiler package conda-forge/noarch::sysroot_linux-64==2.17=h4a8ded7_14
Fixing permissions
Packaged license file/s.
INFO :: Time taken to mark (prefix)
        0 replacements in 0 files was 0.02 seconds
fatal: No names found, cannot describe anything.
WARNING: Importing conda-verify failed.  Please be sure to test your packages.  conda install conda-verify to make this message go away.

And they are not added to the released package:

Loading channels: done
pti-gpu-unitrace 0.0.1 h07fc403_0
---------------------------------
file name   : pti-gpu-unitrace-0.0.1-h07fc403_0.conda
name        : pti-gpu-unitrace
version     : 0.0.1
build       : h07fc403_0
build number: 0
size        : 554 KB
license     : MIT
subdir      : linux-64
url         : file:///home/yevhenii/.miniforge3/conda-bld/linux-64/pti-gpu-unitrace-0.0.1-h07fc403_0.conda
md5         : 5cf84c599f7682c8330470ce9be5c506
timestamp   : 2024-05-20 17:34:16 UTC
dependencies:
  - __glibc >=2.17,<3.0.a0
  - libgcc-ng >=13
  - libstdcxx-ng >=13

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then please make a PR or file an issue with the feedstock that they are missing run_exports and reference it here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed level-zero-feedstock and opened an issues on intel-compilers-repack-feedstock.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pti-gpu-unitrace) and found some lint.

Here's what I've got...

For recipes/pti-gpu-unitrace:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'outputs', 'about', 'extra'].

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pti-gpu-unitrace) and found some lint.

Here's what I've got...

For recipes/pti-gpu-unitrace:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'outputs', 'about', 'extra'].
  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [28]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pti-gpu-unitrace) and found some lint.

Here's what I've got...

For recipes/pti-gpu-unitrace:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [28]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pti-gpu-unitrace) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pti-gpu-unitrace) and found some lint.

Here's what I've got...

For recipes/pti-gpu-unitrace:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [45, 46]

@ZzEeKkAa ZzEeKkAa force-pushed the add/pti-gpu-unitrace branch 2 times, most recently from aca37b8 to d45c1bb Compare June 3, 2024 22:24
@ZzEeKkAa ZzEeKkAa force-pushed the add/pti-gpu-unitrace branch 2 times, most recently from 9ab7e64 to 162c5a2 Compare June 3, 2024 22:39
@ZzEeKkAa ZzEeKkAa requested a review from xhochy June 3, 2024 22:40
@ZzEeKkAa
Copy link
Author

ZzEeKkAa commented Jun 3, 2024

@xhochy I've applied all discussions, but was unable to trigger linter after force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants