-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add libtinyspline #26343
base: main
Are you sure you want to change the base?
add libtinyspline #26343
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tinyspline:
For recipes/tinyspline:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tinyspline:
For recipes/tinyspline:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tinyspline:
|
…ded not available on macos
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tinyspline:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tinyspline:
|
@conda-forge/help-c-cpp , ready for review Questions:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add a lib prefix to distinguish it from the python package.
Also, as this ships shared libraries, it should have a run_exports statement.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@xhochy is that ok? Finally, can we use |
recipes/libtinyspline/meta.yaml
Outdated
requirements: | ||
build: | ||
- cmake | ||
- binutils # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be required.
- binutils # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added binutils
to have the command strip
. Otherwise, the build was failing with "command not found". Also, stripping only works on Linux (and all binaries should be stripped).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a $STRIP
command set that comes in via the compiler. Please use that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the end, I switched to using cmake --install . --strip
instead of manually using the command $STRIP
because cmake knows how to do it across all platforms.
This should work 🤔 I have been doing this in other locations. You need to run these tests though during the build phase of conda-build. |
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
Ah, that's the problem! I was running |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).