-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New GCP Provider: Using kata's main branch #1839
Draft
beraldoleal
wants to merge
8
commits into
confidential-containers:main
Choose a base branch
from
beraldoleal:mainplusgcp
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beraldoleal
force-pushed
the
mainplusgcp
branch
5 times, most recently
from
May 17, 2024 20:11
08c544c
to
3a8f235
Compare
packer for now. Signed-off-by: Cfir Cohen <cfir@google.com>
beraldoleal
force-pushed
the
mainplusgcp
branch
2 times, most recently
from
June 7, 2024 15:15
852f293
to
9dc4be7
Compare
Add support for creating a podvm instance on Google Cloud Platform. Tested using CCA dev image running locally on a kubeadm cluster. Work based on Cfir branch, but rebased by Beraldo with main and adapted to use the new provider layout. Signed-off-by: Cfir Cohen <cfir@google.com> Signed-off-by: Beraldo Leal <bleal@redhat.com> Co-authored-by: Beraldo Leal <bleal@redhat.com>
This should be squashed. Signed-off-by: Beraldo Leal <bleal@redhat.com>
updating go.* files. Signed-off-by: Beraldo Leal <bleal@redhat.com>
updating go.* files Signed-off-by: Beraldo Leal <bleal@redhat.com>
updating go.* files Signed-off-by: Beraldo Leal <bleal@redhat.com>
Lets improve the readability a bit. Signed-off-by: Beraldo Leal <bleal@redhat.com>
And removing deprecated bases. Signed-off-by: Beraldo Leal <bleal@redhat.com>
beraldoleal
changed the title
Draft: New GCP Provider: Using kata's main branch
New GCP Provider: Using kata's main branch
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a quite journey making kata-containers gogoprotobuff free and trying to make caa compatible with kata-containers's main, we are getting really closer to switch to main, thanks to @stevenhorsman's work (PR #1754).
Since the initial attempt from cfircohen (#1212), a lot has changed in our repository and codebase. While doing some internal experiments/tests to predict possible issues with kata's main this week, I had to rebase on top of Steve' work, that is:
I was able to start a container within GCP using CAA + kata-container's main branch:
@alexmwu, Since you are joining the effort, and writing the tests, probably you will need those changes, if not there yet.
!! NOTE: This is a rebase on top #1754, please do not merge yet. !!