Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Creating AppInfo was absolutely spamming the Info logs #10060

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: Creating AppInfo was absolutely spamming the Info logs #10060

wants to merge 2 commits into from

Conversation

wcarlson5
Copy link
Contributor

Description

What behavior do you want to change, why, how does your patch achieve the changes?

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

@wcarlson5 wcarlson5 requested a review from a team as a code owner August 25, 2023 20:01
@cla-assistant
Copy link

cla-assistant bot commented Aug 25, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant
Copy link

cla-assistant bot commented Aug 25, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

stevenpyzhang
stevenpyzhang reviewed Aug 25, 2023
View reviewed changes
ksqldb-rest-app/src/main/java/io/confluent/ksql/rest/server/KsqlRestApplication.java
@@ -785,14 +786,15 @@ static KsqlRestApplication buildApplication(
final Admin internalAdmin = createCommandTopicAdminClient(restConfig, ksqlConfig);
final KafkaTopicClient internalTopicClient = new KafkaTopicClientImpl(() -> internalAdmin);

final AppInfoParser.AppInfo appInfo = new AppInfoParser.AppInfo(System.currentTimeMillis());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be a different app info result than what's in KsqlConfig since the system time would be different?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was being created new with each call anyways. It only records the commit and version so I don't think that should change. Also the call in ksqlConfig was generating like 95% of our log traffic in soak and it was added since the last release

@stevenpyzhang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenpyzhang stevenpyzhang stevenpyzhang left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wcarlson5 @stevenpyzhang